Fix TAC button alignment when expanded (#12238)

pull/28217/head
Florian Duros 2024-02-08 15:09:32 +01:00 committed by GitHub
parent 967695b6ad
commit cf5d9f86fd
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 26 additions and 3 deletions

View File

@ -350,6 +350,20 @@ export class Helpers {
await this.receiveMessages(room2, ["Msg2", msg.threadedOff("Msg2", "Resp2")]); await this.receiveMessages(room2, ["Msg2", msg.threadedOff("Msg2", "Resp2")]);
await this.receiveMessages(room1, ["Msg3", msg.threadedOff("Msg3", "Resp3")]); await this.receiveMessages(room1, ["Msg3", msg.threadedOff("Msg3", "Resp3")]);
} }
/**
* Get the space panel
*/
getSpacePanel() {
return this.page.getByRole("navigation", { name: "Spaces" });
}
/**
* Expand the space panel
*/
expandSpacePanel() {
return this.page.getByRole("button", { name: "Expand" }).click();
}
} }
export { expect }; export { expect };

View File

@ -25,6 +25,15 @@ test.describe("Threads Activity Centre", () => {
labsFlags: ["threadsActivityCentre"], labsFlags: ["threadsActivityCentre"],
}); });
test("should have the button correctly aligned and displayed in the space panel when expanded", async ({
util,
}) => {
// Open the space panel
await util.expandSpacePanel();
// The buttons in the space panel should be aligned when expanded
await expect(util.getSpacePanel()).toMatchScreenshot("tac-button-expanded.png");
});
test("should not show indicator when there is no thread", async ({ roomAlpha: room1, util }) => { test("should not show indicator when there is no thread", async ({ roomAlpha: room1, util }) => {
// No indicator should be shown // No indicator should be shown
await util.assertNoTacIndicator(); await util.assertNoTacIndicator();

Binary file not shown.

After

Width:  |  Height:  |  Size: 15 KiB

View File

@ -19,7 +19,7 @@
.mx_ThreadsActivityCentreButton { .mx_ThreadsActivityCentreButton {
color: $secondary-content; color: $secondary-content;
height: 32px; height: 32px;
width: 32px; min-width: 32px;
display: flex; display: flex;
align-items: center; align-items: center;
justify-content: center; justify-content: center;
@ -28,11 +28,11 @@
&.expanded { &.expanded {
/* align with settings icon */ /* align with settings icon */
margin-left: 20px; margin-left: 25px;
& > .mx_ThreadsActivityCentreButton_IndicatorIcon { & > .mx_ThreadsActivityCentreButton_IndicatorIcon {
/* align with settings label */ /* align with settings label */
margin-right: 12px; margin-right: 14px;
} }
} }