From d12ca92ea7a8ca1067f28ca0e59bda3e1c9ee6e0 Mon Sep 17 00:00:00 2001 From: David Baker Date: Tue, 13 Oct 2015 11:12:06 +0100 Subject: [PATCH] Avoid double updating: setting the state will cause a re-render so forcing an update is redundant. Also bump js sdk dep to newest to match vector. --- package.json | 2 +- src/controllers/organisms/MemberList.js | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/package.json b/package.json index ea2bac9f18..f28cfdf215 100644 --- a/package.json +++ b/package.json @@ -24,7 +24,7 @@ "flux": "^2.0.3", "glob": "^5.0.14", "linkifyjs": "^2.0.0-beta.4", - "matrix-js-sdk": "^0.2.1", + "matrix-js-sdk": "^0.2.2", "optimist": "^0.6.1", "q": "^1.4.1", "react": "^0.13.3", diff --git a/src/controllers/organisms/MemberList.js b/src/controllers/organisms/MemberList.js index 6c3dbb03b2..a8ec965662 100644 --- a/src/controllers/organisms/MemberList.js +++ b/src/controllers/organisms/MemberList.js @@ -75,9 +75,6 @@ module.exports = { if (tile) { self._updateList(); // reorder the membership list - self.forceUpdate(); // FIXME: is the a more efficient way of reordering with react? - // XXX: do we even need to do this, or is it done by the main list? - tile.forceUpdate(); } } // FIXME: we should probably also reset 'lastActiveAgo' to zero whenever