OpenCloud
/
element-web
mirror of https://github.com/vector-im/element-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Enable & fix skipped tests in `new-messages.spec.ts` (#12013)

pull/28788/head^2
Florian Duros 2023-12-08 13:38:39 +01:00 committed by GitHub
parent 6360fe46f3
commit d15065d05c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
playwright/e2e/read-receipts/new-messages.spec.ts
View File

@ -55,8 +55,7 @@ test.describe("Read receipts", () => {
// Then the room becomes read // Then the room becomes read
await util.assertRead(room2); await util.assertRead(room2);
}); });
// XXX: fails (sometimes!) because the unread count stays high test("Reading an older message leaves the room unread", async ({
test.skip("Reading an older message leaves the room unread", async ({
roomAlpha: room1, roomAlpha: room1,
roomBeta: room2, roomBeta: room2,
util, util,
@ -164,27 +163,6 @@ test.describe("Read receipts", () => {
// Then all messages are still read // Then all messages are still read
await util.assertRead(room2); await util.assertRead(room2);
}); });
// XXX: fails because the room remains unread even though I sent a message
// Note: this test should not re-use the same MatrixClient - it
// should create a new one logged in as the same user.
test.skip("Me sending a message from a different client marks room as read", async ({
roomAlpha: room1,
roomBeta: room2,
util,
app,
}) => {
// Given I have unread messages
await util.goTo(room1);
await util.assertRead(room2);
await util.receiveMessages(room2, ["Msg1"]);
await util.assertUnread(room2, 1);
// When I send a new message from a different client
await util.sendMessageAsClient(app.client, room2, ["Msg2"]);
// Then this room is marked as read
await util.assertRead(room2);
});
}); });
test.describe("in threads", () => { test.describe("in threads", () => {
@ -252,8 +230,7 @@ test.describe("Read receipts", () => {
await util.assertReadThread("Msg1"); await util.assertReadThread("Msg1");
await util.assertRead(room2); await util.assertRead(room2);
}); });
// XXX: Fails since migration to Playwright test("Reading an older thread message leaves the thread unread", async ({
test.skip("Reading an older thread message leaves the thread unread", async ({
roomAlpha: room1, roomAlpha: room1,
roomBeta: room2, roomBeta: room2,
util, util,
@ -268,13 +245,8 @@ test.describe("Read receipts", () => {
await util.assertUnread(room2, 21); await util.assertUnread(room2, 21);
// When I read an older message in the thread // When I read an older message in the thread
await msg.jumpTo(room2.name, "InThread0001", true); await msg.jumpTo(room2.name, "InThread0000", true);
await util.assertUnreadLessThan(room2, 21); await util.assertUnreadLessThan(room2, 21);
// TODO: for some reason, we can't find the first message
// "InThread0", so I am using the second here. Also, they appear
// out of order, with "InThread2" before "InThread1". Might be a
// clue to the sporadic reports we have had of messages going
// missing in threads?
// Then the thread is still marked as unread // Then the thread is still marked as unread
await util.backToThreadsList(); await util.backToThreadsList();
@ -499,8 +471,7 @@ test.describe("Read receipts", () => {
await util.assertUnread(room2, 1); await util.assertUnread(room2, 1);
await util.assertUnreadThread("Msg1"); await util.assertUnreadThread("Msg1");
}); });
// XXX: fails because we jump to the wrong place in the timeline test("Reading a thread root within the thread view marks it as read in the main timeline", async ({
test.skip("Reading a thread root within the thread view marks it as read in the main timeline", async ({
roomAlpha: room1, roomAlpha: room1,
roomBeta: room2, roomBeta: room2,
util, util,
@ -518,11 +489,12 @@ test.describe("Read receipts", () => {
// When I jump to an old message and read the thread // When I jump to an old message and read the thread
await msg.jumpTo(room2.name, "beforeThread0000"); await msg.jumpTo(room2.name, "beforeThread0000");
// When the thread is opened, the timeline is scrolled until the thread root reached the center
await util.openThread("ThreadRoot"); await util.openThread("ThreadRoot");
// Then the thread root is marked as read in the main timeline, // Then the thread root is marked as read in the main timeline,
// so there are only 30 left - the ones after the thread root. // 30 remaining messages are unread - 7 messages are displayed under the thread root
await util.assertUnread(room2, 30); await util.assertUnread(room2, 30 - 7);
}); });
test("Creating a new thread based on a reply makes the room unread", async ({ test("Creating a new thread based on a reply makes the room unread", async ({
roomAlpha: room1, roomAlpha: room1,