Merge pull request #18774 from vector-im/travis/i-hate-the-error-dialog-that-gets-in-my-way-and-still-doesnt-take-focus-so-i-break-things-in-devtools

Disable HMR error page by default

.env.example

@@ -1,5 +1,7 @@
 # To enable CSS hot-reload, set the following variable to 1.
 CSS_HOT_RELOAD=1
+# To use the annoying and inconsistent full page error dialog, set this to 1.
+FULL_PAGE_ERRORS=0
 # To use a single theme, uncomment the line with the theme you want to hot-reload.
 MATRIX_THEMES='light'
 #MATRIX_THEMES='dark'

webpack.config.js

@@ -48,6 +48,7 @@ module.exports = (env, argv) => {
     }
     const devMode = nodeEnv !== 'production';
     const useHMR = process.env.CSS_HOT_RELOAD === '1' && devMode;
+    const fullPageErrors = process.env.FULL_PAGE_ERRORS === '1' && devMode;
 
     const development = {};
     if (argv.mode === "production") {
@@ -525,7 +526,7 @@ module.exports = (env, argv) => {
             new HtmlWebpackInjectPreload({
                 files: [{ match: /.*Inter.*\.woff2$/ }],
             }),
-            useHMR && new ReactRefreshWebpackPlugin(),
+            useHMR && new ReactRefreshWebpackPlugin(fullPageErrors ? undefined : { overlay: { entry: false } }),
 
         ].filter(Boolean),