OpenCloud
/
element-web
mirror of https://github.com/vector-im/element-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Merge pull request #18774 from vector-im/travis/i-hate-the-error-dialog-that-gets-in-my-way-and-still-doesnt-take-focus-so-i-break-things-in-devtools 

Disable HMR error page by default
pull/18823/head
Travis Ralston 2021-08-25 10:05:34 -06:00 committed by GitHub
parent f8eb1d17f9 219ea134ca
commit d5d7fe64f5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.env.example
View File

@ -1,5 +1,7 @@
# To enable CSS hot-reload, set the following variable to 1. # To enable CSS hot-reload, set the following variable to 1.
CSS_HOT_RELOAD=1 CSS_HOT_RELOAD=1
# To use the annoying and inconsistent full page error dialog, set this to 1.
FULL_PAGE_ERRORS=0
# To use a single theme, uncomment the line with the theme you want to hot-reload. # To use a single theme, uncomment the line with the theme you want to hot-reload.
MATRIX_THEMES='light' MATRIX_THEMES='light'
#MATRIX_THEMES='dark' #MATRIX_THEMES='dark'

3
webpack.config.js
View File

@ -48,6 +48,7 @@ module.exports = (env, argv) => {
} }
const devMode = nodeEnv !== 'production'; const devMode = nodeEnv !== 'production';
const useHMR = process.env.CSS_HOT_RELOAD === '1' && devMode; const useHMR = process.env.CSS_HOT_RELOAD === '1' && devMode;
const fullPageErrors = process.env.FULL_PAGE_ERRORS === '1' && devMode;
const development = {}; const development = {};
if (argv.mode === "production") { if (argv.mode === "production") {
@ -525,7 +526,7 @@ module.exports = (env, argv) => {
new HtmlWebpackInjectPreload({ new HtmlWebpackInjectPreload({
files: [{ match: /.*Inter.*\.woff2$/ }], files: [{ match: /.*Inter.*\.woff2$/ }],
}), }),
useHMR && new ReactRefreshWebpackPlugin(), useHMR && new ReactRefreshWebpackPlugin(fullPageErrors ? undefined : { overlay: { entry: false } }),
].filter(Boolean), ].filter(Boolean),