From d6d3585c301893eee38af231db88df98dcfde855 Mon Sep 17 00:00:00 2001 From: Florian Duros Date: Thu, 7 Dec 2023 11:29:25 +0100 Subject: [PATCH] Playwright: Enable more tests in `editing-messages.spec.ts` (#12001) * Enable skipped test in `editing-messages.spec.ts` * Enable 2 more tests in `editing-messages.spec.ts` * Fix `A room where all threaded edits are read is still read after restart` integ test * Fix `A room where all threaded edits are read is still read after restart` integ test * WIP fix `A room where all threaded edits are read is still read after restart ` * WIP fix `A room where all threaded edits are read is still read after restart ` --- .../read-receipts/editing-messages.spec.ts | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/playwright/e2e/read-receipts/editing-messages.spec.ts b/playwright/e2e/read-receipts/editing-messages.spec.ts index f10263da5e..49db3bdfbe 100644 --- a/playwright/e2e/read-receipts/editing-messages.spec.ts +++ b/playwright/e2e/read-receipts/editing-messages.spec.ts @@ -287,20 +287,20 @@ test.describe("Read receipts", () => { // Then is it still read await util.assertRead(room2); }); - // XXX: Failing since migration to Playwright - test.skip("A room where all threaded edits are read is still read after restart", async ({ + test("A room where all threaded edits are read is still read after restart", async ({ roomAlpha: room1, roomBeta: room2, util, msg, }) => { + await util.goTo(room1); + await util.receiveMessages(room2, ["Msg1", msg.threadedOff("Msg1", "Resp1")]); + await util.assertUnread(room2, 2); + await util.receiveMessages(room2, [msg.editOf("Resp1", "Edit1")]); + await util.assertUnread(room2, 2); + await util.goTo(room2); - await util.receiveMessages(room2, [ - "Msg1", - msg.threadedOff("Msg1", "Resp1"), - msg.editOf("Resp1", "Edit1"), - ]); - await util.assertUnread(room2, 1); + await util.openThread("Msg1"); await util.assertRead(room2); await util.goTo(room1); // Make sure we are looking at room1 after reload @@ -309,8 +309,7 @@ test.describe("Read receipts", () => { await util.saveAndReload(); await util.assertRead(room2); }); - // XXX: fails because the room becomes unread after restart - test.skip("A room where all threaded edits are marked as read is still read after restart", async ({ + test("A room where all threaded edits are marked as read is still read after restart", async ({ roomAlpha: room1, roomBeta: room2, util,