Merge pull request #4509 from matrix-org/bwindels/dontencryptfor3pids

Don't enable e2ee when inviting a 3pid
pull/21833/head
Bruno Windels 2020-04-29 09:49:28 +00:00 committed by GitHub
commit d9469e6afe
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 4 deletions

View File

@ -577,10 +577,13 @@ export default class InviteDialog extends React.PureComponent {
if (SettingsStore.getValue("feature_cross_signing")) { if (SettingsStore.getValue("feature_cross_signing")) {
// Check whether all users have uploaded device keys before. // Check whether all users have uploaded device keys before.
// If so, enable encryption in the new room. // If so, enable encryption in the new room.
const client = MatrixClientPeg.get(); const has3PidMembers = targets.some(t => t instanceof ThreepidMember);
const allHaveDeviceKeys = await canEncryptToAllUsers(client, targetIds); if (!has3PidMembers) {
if (allHaveDeviceKeys) { const client = MatrixClientPeg.get();
createRoomOptions.encryption = true; const allHaveDeviceKeys = await canEncryptToAllUsers(client, targetIds);
if (allHaveDeviceKeys) {
createRoomOptions.encryption = true;
}
} }
} }