From d9909864071985f884189aba751755b5ca7cb89f Mon Sep 17 00:00:00 2001
From: Michael Telatynski <7t3chguy@gmail.com>
Date: Wed, 16 Sep 2020 10:37:15 +0100
Subject: [PATCH] Also hide Privacy heading in settings and fix React Key
 warning

---
 .../views/settings/SecureBackupPanel.js       |  8 ++--
 .../tabs/user/SecurityUserSettingsTab.js      | 38 ++++++++++---------
 2 files changed, 24 insertions(+), 22 deletions(-)

diff --git a/src/components/views/settings/SecureBackupPanel.js b/src/components/views/settings/SecureBackupPanel.js
index 7f0655d54a..c058e27de7 100644
--- a/src/components/views/settings/SecureBackupPanel.js
+++ b/src/components/views/settings/SecureBackupPanel.js
@@ -367,14 +367,14 @@ export default class SecureBackupPanel extends React.PureComponent {
             </>;
 
             actions.push(
-                <AccessibleButton kind="primary" onClick={this._restoreBackup}>
+                <AccessibleButton kind="primary" onClick={this._restoreBackup} key="restoreButton">
                     {restoreButtonCaption}
                 </AccessibleButton>,
             );
 
             if (!isSecureBackupRequired()) {
                 actions.push(
-                    <AccessibleButton kind="danger" onClick={this._deleteBackup}>
+                    <AccessibleButton kind="danger" onClick={this._deleteBackup} key="deleteButton">
                         {_t("Delete Backup")}
                     </AccessibleButton>,
                 );
@@ -388,7 +388,7 @@ export default class SecureBackupPanel extends React.PureComponent {
                 <p>{_t("Back up your keys before signing out to avoid losing them.")}</p>
             </>;
             actions.push(
-                <AccessibleButton kind="primary" onClick={this._startNewBackup}>
+                <AccessibleButton kind="primary" onClick={this._startNewBackup} key="setupButton">
                     {_t("Set up")}
                 </AccessibleButton>,
             );
@@ -396,7 +396,7 @@ export default class SecureBackupPanel extends React.PureComponent {
 
         if (secretStorageKeyInAccount) {
             actions.push(
-                <AccessibleButton kind="danger" onClick={this._resetSecretStorage}>
+                <AccessibleButton kind="danger" onClick={this._resetSecretStorage} key="resetButton">
                     {_t("Reset")}
                 </AccessibleButton>,
             );
diff --git a/src/components/views/settings/tabs/user/SecurityUserSettingsTab.js b/src/components/views/settings/tabs/user/SecurityUserSettingsTab.js
index 03093d2dca..0c49f108d6 100644
--- a/src/components/views/settings/tabs/user/SecurityUserSettingsTab.js
+++ b/src/components/views/settings/tabs/user/SecurityUserSettingsTab.js
@@ -329,24 +329,27 @@ export default class SecurityUserSettingsTab extends React.Component {
             </div>;
         }
 
-        let analyticsSection;
+        let privacySection;
         if (Analytics.canEnable()) {
-            analyticsSection = <div className="mx_SettingsTab_section">
-                <span className="mx_SettingsTab_subheading">{_t("Analytics")}</span>
-                <div className='mx_SettingsTab_subsectionText'>
-                    {_t(
-                        "%(brand)s collects anonymous analytics to allow us to improve the application.",
-                        { brand },
-                    )}
-                    &nbsp;
-                    {_t("Privacy is important to us, so we don't collect any personal or " +
-                        "identifiable data for our analytics.")}
-                    <AccessibleButton className="mx_SettingsTab_linkBtn" onClick={Analytics.showDetailsModal}>
-                        {_t("Learn more about how we use analytics.")}
-                    </AccessibleButton>
+            privacySection = <React.Fragment>
+                <div className="mx_SettingsTab_heading">{_t("Privacy")}</div>
+                <div className="mx_SettingsTab_section">
+                    <span className="mx_SettingsTab_subheading">{_t("Analytics")}</span>
+                    <div className="mx_SettingsTab_subsectionText">
+                        {_t(
+                            "%(brand)s collects anonymous analytics to allow us to improve the application.",
+                            { brand },
+                        )}
+                        &nbsp;
+                        {_t("Privacy is important to us, so we don't collect any personal or " +
+                            "identifiable data for our analytics.")}
+                        <AccessibleButton className="mx_SettingsTab_linkBtn" onClick={Analytics.showDetailsModal}>
+                            {_t("Learn more about how we use analytics.")}
+                        </AccessibleButton>
+                    </div>
+                    <SettingsFlag name="analyticsOptIn" level={SettingLevel.DEVICE} onChange={this._updateAnalytics} />
                 </div>
-                <SettingsFlag name='analyticsOptIn' level={SettingLevel.DEVICE} onChange={this._updateAnalytics} />
-            </div>;
+            </React.Fragment>;
         }
 
         return (
@@ -377,8 +380,7 @@ export default class SecurityUserSettingsTab extends React.Component {
                     {crossSigning}
                     {this._renderCurrentDeviceInfo()}
                 </div>
-                <div className="mx_SettingsTab_heading">{_t("Privacy")}</div>
-                { analyticsSection }
+                { privacySection }
                 <div className="mx_SettingsTab_heading">{_t("Advanced")}</div>
                 <div className="mx_SettingsTab_section">
                     {this._renderIgnoredUsers()}