OpenCloud
/
element-web
mirror of https://github.com/vector-im/element-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Merge pull request #2894 from matrix-org/travis/breadcrumbs/ratelimit 

Send breadcrumb updates only when they change
pull/21833/head
Travis Ralston 2019-04-09 09:58:04 -06:00 committed by GitHub
parent 44e33ba5f1 43362bfb98
commit daaedb8291
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/components/views/rooms/RoomBreadcrumbs.js
View File

@ -94,11 +94,6 @@ export default class RoomBreadcrumbs extends React.Component {
setTimeout(() => this.setState({rooms}), 0); setTimeout(() => this.setState({rooms}), 0);
} }
} }
const roomIds = rooms.map((r) => r.room.roomId);
if (roomIds.length > 0) {
SettingsStore.setValue("breadcrumb_rooms", null, SettingLevel.ACCOUNT, roomIds);
}
} }
onAction(payload) { onAction(payload) {
@ -252,6 +247,14 @@ export default class RoomBreadcrumbs extends React.Component {
if (this.refs.scroller) { if (this.refs.scroller) {
this.refs.scroller.moveToOrigin(); this.refs.scroller.moveToOrigin();
} }
// We don't track room aesthetics (badges, membership, etc) over the wire so we
// don't need to do this elsewhere in the file. Just where we alter the room IDs
// and their order.
const roomIds = rooms.map((r) => r.room.roomId);
if (roomIds.length > 0) {
SettingsStore.setValue("breadcrumb_rooms", null, SettingLevel.ACCOUNT, roomIds);
}
} }
_viewRoom(room, index) { _viewRoom(room, index) {