OpenCloud
/
element-web
mirror of https://github.com/vector-im/element-web
1
0
Fork 0
Code Issues Releases Wiki Activity

extract constant

pull/21833/head
Bruno Windels 2019-05-27 16:45:26 +02:00
parent 651cb8b9a7
commit dee24ac27a
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/utils/EventUtils.js
View File

@ -61,6 +61,7 @@ export function canEditOwnEvent(mxEvent) {
return canEditContent(mxEvent); return canEditContent(mxEvent);
} }
const MAX_JUMP_DISTANCE = 100;
export function findEditableEvent(room, isForward, fromEventId = undefined) { export function findEditableEvent(room, isForward, fromEventId = undefined) {
const liveTimeline = room.getLiveTimeline(); const liveTimeline = room.getLiveTimeline();
const events = liveTimeline.getEvents(); const events = liveTimeline.getEvents();
@ -69,7 +70,7 @@ export function findEditableEvent(room, isForward, fromEventId = undefined) {
const beginIdx = isForward ? 0 : maxIdx; const beginIdx = isForward ? 0 : maxIdx;
let endIdx = isForward ? maxIdx : 0; let endIdx = isForward ? maxIdx : 0;
if (!fromEventId) { if (!fromEventId) {
endIdx = Math.min(Math.max(0, beginIdx + (inc * 100)), maxIdx); endIdx = Math.min(Math.max(0, beginIdx + (inc * MAX_JUMP_DISTANCE)), maxIdx);
} }
let foundFromEventId = !fromEventId; let foundFromEventId = !fromEventId;
for (let i = beginIdx; i !== (endIdx + inc); i += inc) { for (let i = beginIdx; i !== (endIdx + inc); i += inc) {
@ -77,9 +78,9 @@ export function findEditableEvent(room, isForward, fromEventId = undefined) {
// find start event first // find start event first
if (!foundFromEventId && e.getId() === fromEventId) { if (!foundFromEventId && e.getId() === fromEventId) {
foundFromEventId = true; foundFromEventId = true;
// don't look further than 100 events from `fromEventId` // don't look further than MAX_JUMP_DISTANCE events from `fromEventId`
// to not iterate potentially 1000nds of events on key up/down // to not iterate potentially 1000nds of events on key up/down
endIdx = Math.min(Math.max(0, i + (inc * 100)), maxIdx); endIdx = Math.min(Math.max(0, i + (inc * MAX_JUMP_DISTANCE)), maxIdx);
} else if (foundFromEventId && !shouldHideEvent(e) && canEditOwnEvent(e)) { } else if (foundFromEventId && !shouldHideEvent(e) && canEditOwnEvent(e)) {
// otherwise look for editable event // otherwise look for editable event
return e; return e;