Explain that full URL is sent to Piwik

Also, redesign analytics modal to be one big table, instead of table +
paragraph.
pull/21833/head
Luke Barnard 2018-04-26 10:59:43 +01:00
parent 1ff11ca493
commit e16c50d4be
2 changed files with 26 additions and 13 deletions

View File

@ -251,3 +251,7 @@ input.mx_UserSettings_phoneNumberField {
color: $accent-color; color: $accent-color;
word-break: break-all; word-break: break-all;
} }
.mx_UserSettings_analyticsModal table {
margin: 10px 0px;
}

View File

@ -210,11 +210,25 @@ class Analytics {
const rows = Object.values(customVariables).map((v) => Tracker.getCustomVariable(v.id)).filter(Boolean); const rows = Object.values(customVariables).map((v) => Tracker.getCustomVariable(v.id)).filter(Boolean);
const resolution = `${window.screen.width}x${window.screen.height}`; const resolution = `${window.screen.width}x${window.screen.height}`;
const otherVariables = [
{
expl: _td('Every page you use in the app'),
value: _t(
'e.g. <CurrentPageURL>',
{},
{
CurrentPageURL: getRedactedUrl(),
},
),
},
{ expl: _td('Your User Agent'), value: navigator.userAgent },
{ expl: _td('Your device resolution'), value: resolution },
];
const ErrorDialog = sdk.getComponent('dialogs.ErrorDialog'); const ErrorDialog = sdk.getComponent('dialogs.ErrorDialog');
Modal.createTrackedDialog('Analytics Details', '', ErrorDialog, { Modal.createTrackedDialog('Analytics Details', '', ErrorDialog, {
title: _t('Analytics'), title: _t('Analytics'),
description: <div> description: <div className="mx_UserSettings_analyticsModal">
<div> <div>
{ _t('The information being sent to us to help make Riot.im better includes:') } { _t('The information being sent to us to help make Riot.im better includes:') }
</div> </div>
@ -223,19 +237,14 @@ class Analytics {
<td>{ _t(customVariables[row[0]].expl) }</td> <td>{ _t(customVariables[row[0]].expl) }</td>
<td><code>{ row[1] }</code></td> <td><code>{ row[1] }</code></td>
</tr>) } </tr>) }
</table> { otherVariables.map((item, index) =>
<br /> <tr key={index}>
<div> <td>{ _t(item.expl) }</td>
{ _t('We also record each page you use in the app (currently <CurrentPageHash>), your User Agent' <td><code>{ item.value }</code></td>
+ ' (<CurrentUserAgent>) and your device resolution (<CurrentDeviceResolution>).', </tr>,
{},
{
CurrentPageHash: <code>{ getRedactedHash() }</code>,
CurrentUserAgent: <code>{ navigator.userAgent }</code>,
CurrentDeviceResolution: <code>{ resolution }</code>,
},
) } ) }
</table>
<div>
{ _t('Where this page includes identifiable information, such as a room, ' { _t('Where this page includes identifiable information, such as a room, '
+ 'user or group ID, that data is removed before being sent to the server.') } + 'user or group ID, that data is removed before being sent to the server.') }
</div> </div>