OpenCloud
/
element-web
mirror of https://github.com/vector-im/element-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Posthog properly handle Analytics ID changing from under us (#10702) 

* Posthog properly handle Analytics ID changing from under us

* Update tests
pull/28788/head^2
Michael Telatynski 2023-04-26 09:03:35 +01:00 committed by GitHub
parent 857e22f943
commit e4610e4672
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/PosthogAnalytics.ts
View File

@ -312,6 +312,14 @@ export class PosthogAnalytics {
Object.assign({ id: analyticsID }, accountData), Object.assign({ id: analyticsID }, accountData),
); );
} }
if (this.posthog.get_distinct_id() === analyticsID) {
// No point identifying again
return;
}
if (this.posthog.persistence.get_user_state() === "identified") {
// Analytics ID has changed, reset as Posthog will refuse to merge in this case
this.posthog.reset();
}
this.posthog.identify(analyticsID); this.posthog.identify(analyticsID);
} catch (e) { } catch (e) {
// The above could fail due to network requests, but not essential to starting the application, // The above could fail due to network requests, but not essential to starting the application,

4
test/PosthogAnalytics-test.ts
View File

@ -33,6 +33,10 @@ const getFakePosthog = (): PostHog =>
identify: jest.fn(), identify: jest.fn(),
reset: jest.fn(), reset: jest.fn(),
register: jest.fn(), register: jest.fn(),
get_distinct_id: jest.fn(),
persistence: {
get_user_state: jest.fn(),
},
} as unknown as PostHog); } as unknown as PostHog);
interface ITestEvent extends IPosthogEvent { interface ITestEvent extends IPosthogEvent {