Merge pull request #683 from matrix-org/luke/mels-xor

MELS: either expanded or summary, not both
pull/21833/head
Luke Barnard 2017-03-02 14:08:06 +00:00 committed by GitHub
commit e75c21e9f9
1 changed files with 17 additions and 20 deletions

View File

@ -111,7 +111,7 @@ module.exports = React.createClass({
}
return (
<span>
<span className="mx_TextualEvent mx_MemberEventListSummary_summary">
{summaries.join(", ")}
</span>
);
@ -267,7 +267,7 @@ module.exports = React.createClass({
);
});
return (
<span>
<span className="mx_MemberEventListSummary_avatars">
{avatars}
</span>
);
@ -400,31 +400,28 @@ module.exports = React.createClass({
(seq1, seq2) => aggregate.indices[seq1] > aggregate.indices[seq2]
);
const avatars = this._renderAvatars(avatarMembers);
const summary = this._renderSummary(aggregate.names, orderedTransitionSequences);
const toggleButton = (
<a className="mx_MemberEventListSummary_toggle" onClick={this._toggleSummary}>
{expanded ? 'collapse' : 'expand'}
</a>
);
const summaryContainer = (
<div className="mx_EventTile_line">
<div className="mx_EventTile_info">
<span className="mx_MemberEventListSummary_avatars">
{avatars}
</span>
<span className="mx_TextualEvent mx_MemberEventListSummary_summary">
{summary}
</span>&nbsp;
{toggleButton}
let summaryContainer = null;
if (!expanded) {
summaryContainer = (
<div className="mx_EventTile_line">
<div className="mx_EventTile_info">
{this._renderAvatars(avatarMembers)}
{this._renderSummary(aggregate.names, orderedTransitionSequences)}
</div>
</div>
);
}
const toggleButton = (
<div className={"mx_MemberEventListSummary_toggle"} onClick={this._toggleSummary}>
{expanded ? 'collapse' : 'expand'}
</div>
);
return (
<div className="mx_MemberEventListSummary">
{toggleButton}
{summaryContainer}
{expanded ? <div className="mx_MemberEventListSummary_line">&nbsp;</div> : null}
{expandedEvents}
</div>
);