From b02b37125014bc160767c1ac811538b922d46ee5 Mon Sep 17 00:00:00 2001
From: Michael Telatynski <7t3chguy@gmail.com>
Date: Sun, 24 Feb 2019 01:06:53 +0000
Subject: [PATCH 1/3] Allow configuration of whether closing window closes or
 minimizes to tray

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
---
 src/BasePlatform.js                           | 25 +++++++++++++++++
 .../settings/tabs/PreferencesSettingsTab.js   | 28 +++++++++++++++++--
 src/i18n/strings/en_EN.json                   |  1 +
 3 files changed, 51 insertions(+), 3 deletions(-)

diff --git a/src/BasePlatform.js b/src/BasePlatform.js
index 79f0d69e2c..cac8c36267 100644
--- a/src/BasePlatform.js
+++ b/src/BasePlatform.js
@@ -113,4 +113,29 @@ export default class BasePlatform {
     reload() {
         throw new Error("reload not implemented!");
     }
+
+    supportsAutoLaunch() {
+        return false;
+    }
+
+    // XXX: Surely this should be a setting like any other?
+    async getAutoLaunchEnabled() {
+        return false;
+    }
+
+    async setAutoLaunchEnabled(enabled) {
+        throw new Error("Unimplemented");
+    }
+
+    supportsMinimizeToTray() {
+        return false;
+    }
+
+    async getMinimizeToTrayEnabled() {
+        return false;
+    }
+
+    async setMinimizeToTrayEnabled() {
+        throw new Error("Unimplemented");
+    }
 }
diff --git a/src/components/views/settings/tabs/PreferencesSettingsTab.js b/src/components/views/settings/tabs/PreferencesSettingsTab.js
index d76dc8f3dd..b6273c5d47 100644
--- a/src/components/views/settings/tabs/PreferencesSettingsTab.js
+++ b/src/components/views/settings/tabs/PreferencesSettingsTab.js
@@ -59,24 +59,39 @@ export default class PreferencesSettingsTab extends React.Component {
         this.state = {
             autoLaunch: false,
             autoLaunchSupported: false,
+            minimizeToTray: true,
+            minimizeToTraySupported: false,
         };
     }
 
     async componentWillMount(): void {
-        const autoLaunchSupported = await PlatformPeg.get().supportsAutoLaunch();
+        const platform = PlatformPeg.get();
+
+        const autoLaunchSupported = await platform.supportsAutoLaunch();
         let autoLaunch = false;
 
         if (autoLaunchSupported) {
-            autoLaunch = await PlatformPeg.get().getAutoLaunchEnabled();
+            autoLaunch = await platform.getAutoLaunchEnabled();
         }
 
-        this.setState({autoLaunch, autoLaunchSupported});
+        const minimizeToTraySupported = await platform.supportsMinimizeToTray();
+        let minimizeToTray = true;
+
+        if (minimizeToTraySupported) {
+            minimizeToTray = await platform.getMinimizeToTrayEnabled();
+        }
+
+        this.setState({autoLaunch, autoLaunchSupported, minimizeToTraySupported, minimizeToTray});
     }
 
     _onAutoLaunchChange = (checked) => {
         PlatformPeg.get().setAutoLaunchEnabled(checked).then(() => this.setState({autoLaunch: checked}));
     };
 
+    _onMinimizeToTrayChange = (checked) => {
+        PlatformPeg.get().setMinimizeToTrayEnabled(checked).then(() => this.setState({minimizeToTray: checked}));
+    };
+
     _onAutocompleteDelayChange = (e) => {
         SettingsStore.setValue("autocompleteDelay", null, SettingLevel.DEVICE, e.target.value);
     };
@@ -93,6 +108,12 @@ export default class PreferencesSettingsTab extends React.Component {
                                                      onChange={this._onAutoLaunchChange}
                                                      label={_t('Start automatically after system login')} />;
         }
+        let minimizeToTrayOption = null;
+        if (this.state.minimizeToTraySupported) {
+            minimizeToTrayOption = <LabelledToggleSwitch value={this.state.minimizeToTray}
+                                                         onChange={this._onMinimizeToTrayChange}
+                                                         label={_t('Close button should minimize window to tray')} />;
+        }
 
         return (
             <div className="mx_SettingsTab mx_PreferencesSettingsTab">
@@ -106,6 +127,7 @@ export default class PreferencesSettingsTab extends React.Component {
 
                     <span className="mx_SettingsTab_subheading">{_t("Advanced")}</span>
                     {this._renderGroup(PreferencesSettingsTab.ADVANCED_SETTINGS)}
+                    {minimizeToTrayOption}
                     {autoLaunchOption}
                     <Field id={"autocompleteDelay"} label={_t('Autocomplete delay (ms)')} type='number'
                            value={SettingsStore.getValueAt(SettingLevel.DEVICE, 'autocompleteDelay')}
diff --git a/src/i18n/strings/en_EN.json b/src/i18n/strings/en_EN.json
index 84c9dacd07..0bc7b55484 100644
--- a/src/i18n/strings/en_EN.json
+++ b/src/i18n/strings/en_EN.json
@@ -551,6 +551,7 @@
     "Labs": "Labs",
     "Notifications": "Notifications",
     "Start automatically after system login": "Start automatically after system login",
+    "Close button should minimize window to tray": "Close button should minimize window to tray",
     "Preferences": "Preferences",
     "Composer": "Composer",
     "Timeline": "Timeline",

From 45e9dbe49d46589b63fdca1b4996ad719026d283 Mon Sep 17 00:00:00 2001
From: Michael Telatynski <7t3chguy@gmail.com>
Date: Sun, 24 Feb 2019 01:20:49 +0000
Subject: [PATCH 2/3] delint

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
---
 src/BasePlatform.js | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/BasePlatform.js b/src/BasePlatform.js
index cac8c36267..c553c9fcd2 100644
--- a/src/BasePlatform.js
+++ b/src/BasePlatform.js
@@ -114,28 +114,28 @@ export default class BasePlatform {
         throw new Error("reload not implemented!");
     }
 
-    supportsAutoLaunch() {
+    supportsAutoLaunch(): boolean {
         return false;
     }
 
     // XXX: Surely this should be a setting like any other?
-    async getAutoLaunchEnabled() {
+    async getAutoLaunchEnabled(): boolean {
         return false;
     }
 
-    async setAutoLaunchEnabled(enabled) {
+    async setAutoLaunchEnabled(enabled: boolean) {
         throw new Error("Unimplemented");
     }
 
-    supportsMinimizeToTray() {
+    supportsMinimizeToTray(): boolean {
         return false;
     }
 
-    async getMinimizeToTrayEnabled() {
+    async getMinimizeToTrayEnabled(): boolean {
         return false;
     }
 
-    async setMinimizeToTrayEnabled() {
+    async setMinimizeToTrayEnabled(enabled: boolean) {
         throw new Error("Unimplemented");
     }
 }

From 4472c66b968ca7a1c75db974799d4ce701e3c836 Mon Sep 17 00:00:00 2001
From: Michael Telatynski <7t3chguy@gmail.com>
Date: Sun, 24 Feb 2019 01:38:31 +0000
Subject: [PATCH 3/3] delint s'more

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
---
 src/BasePlatform.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/BasePlatform.js b/src/BasePlatform.js
index c553c9fcd2..54310d1849 100644
--- a/src/BasePlatform.js
+++ b/src/BasePlatform.js
@@ -123,7 +123,7 @@ export default class BasePlatform {
         return false;
     }
 
-    async setAutoLaunchEnabled(enabled: boolean) {
+    async setAutoLaunchEnabled(enabled: boolean): void {
         throw new Error("Unimplemented");
     }
 
@@ -135,7 +135,7 @@ export default class BasePlatform {
         return false;
     }
 
-    async setMinimizeToTrayEnabled(enabled: boolean) {
+    async setMinimizeToTrayEnabled(enabled: boolean): void {
         throw new Error("Unimplemented");
     }
 }