OpenCloud
/
element-web
mirror of https://github.com/vector-im/element-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Do not resume voice broadcasts on seek (#9686)

pull/28788/head^2
Michael Weimann 2022-12-05 09:43:47 +01:00 committed by GitHub
parent 2d9fa81cf5
commit f117548b38
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/voice-broadcast/models/VoiceBroadcastPlayback.ts
View File

@ -387,7 +387,7 @@ export class VoiceBroadcastPlayback
const offsetInChunk = time - this.chunkEvents.getLengthTo(event); const offsetInChunk = time - this.chunkEvents.getLengthTo(event);
await skipToPlayback.skipTo(offsetInChunk / 1000); await skipToPlayback.skipTo(offsetInChunk / 1000);
if (currentPlayback !== skipToPlayback) { if (this.state === VoiceBroadcastPlaybackState.Playing && !skipToPlayback.isPlaying) {
await skipToPlayback.play(); await skipToPlayback.play();
} }

11
test/voice-broadcast/models/VoiceBroadcastPlayback-test.ts
View File

@ -407,6 +407,17 @@ describe("VoiceBroadcastPlayback", () => {
describe("and calling stop", () => { describe("and calling stop", () => {
stopPlayback(); stopPlayback();
itShouldSetTheStateTo(VoiceBroadcastPlaybackState.Stopped); itShouldSetTheStateTo(VoiceBroadcastPlaybackState.Stopped);
describe("and skipping to somewhere in the middle of the first chunk", () => {
beforeEach(async () => {
mocked(chunk1Playback.play).mockClear();
await playback.skipTo(1);
});
it("should not start the playback", () => {
expect(chunk1Playback.play).not.toHaveBeenCalled();
});
});
}); });
describe("and calling destroy", () => { describe("and calling destroy", () => {