Nest ifs to avoid unnecessary work

pull/21833/head
David Baker 2018-07-27 18:58:11 +01:00
parent e059a08d7b
commit f4c073ad45
1 changed files with 6 additions and 7 deletions

View File

@ -259,16 +259,15 @@ const LoggedInView = React.createClass({
// When the panels are disabled, clicking on them results in a mouse event
// which bubbles to certain elements in the tree. When this happens, close
// any settings page that is currently open (user/room/group).
const targetClasses = new Set(ev.target.className.split(' '));
if (this.props.leftDisabled &&
this.props.rightDisabled &&
(
if (this.props.leftDisabled && this.props.rightDisabled) {
const targetClasses = new Set(ev.target.className.split(' '));
if (
targetClasses.has('mx_MatrixChat') ||
targetClasses.has('mx_MatrixChat_middlePanel') ||
targetClasses.has('mx_RoomView')
)
) {
dis.dispatch({ action: 'close_settings' });
) {
dis.dispatch({ action: 'close_settings' });
}
}
},