Prefer null to falsy, use correct plural
							parent
							
								
									1a4df38500
								
							
						
					
					
						commit
						f71ac93946
					
				|  | @ -103,7 +103,7 @@ module.exports = React.createClass({ | |||
|                 </span> | ||||
|             ); | ||||
|         } | ||||
|         let leaveSummary = ''; | ||||
|         let leaveSummary = null; | ||||
|         if (leavers) { | ||||
|             leaveSummary = ( | ||||
|                 <span> | ||||
|  | @ -186,7 +186,8 @@ module.exports = React.createClass({ | |||
|             toggleButton = ( | ||||
|                 <a onClick={this._toggleSummary}>{expanded?'collapse':'expand'}</a> | ||||
|             ); | ||||
|             let noun = (joinAndLeft === 1 ? 'user' : 'others'); | ||||
|             let plural = (joinEvents.length + leaveEvents.length > 0) ? 'others' : 'users'; | ||||
|             let noun = (joinAndLeft === 1 ? 'user' : plural); | ||||
| 
 | ||||
|             summaryContainer = ( | ||||
|                 <div className="mx_EventTile_line"> | ||||
|  |  | |||
		Loading…
	
		Reference in New Issue
	
	 Luke Barnard
						Luke Barnard