Add TODO after spending 15 mins trying to figure out the difference between props.collapsed and state.hidden
parent
869c08a790
commit
f7c4cca675
|
@ -64,6 +64,11 @@ var RoomSubList = React.createClass({
|
|||
bottommost: React.PropTypes.bool,
|
||||
selectedRoom: React.PropTypes.string.isRequired,
|
||||
activityMap: React.PropTypes.object.isRequired,
|
||||
|
||||
// TODO: Fix the name of this. This is too easily confused with the
|
||||
// "hidden" state which is the expanded (or not) view of the list of rooms.
|
||||
// What this prop *really* does is control whether the room name is displayed
|
||||
// so it should be named as such.
|
||||
collapsed: React.PropTypes.bool.isRequired,
|
||||
onHeaderClick: React.PropTypes.func,
|
||||
alwaysShowHeader: React.PropTypes.bool
|
||||
|
|
Loading…
Reference in New Issue