diff --git a/src/AddThreepid.js b/src/AddThreepid.js index a04e1c2653..3b66b1d7ee 100644 --- a/src/AddThreepid.js +++ b/src/AddThreepid.js @@ -119,10 +119,30 @@ export default class AddThreepid { * @param {string} phoneNumber The national or international formatted phone number to add * @return {Promise} Resolves when the text message has been sent. Then call haveMsisdnToken(). */ - bindMsisdn(phoneCountry, phoneNumber) { + async bindMsisdn(phoneCountry, phoneNumber) { this.bind = true; - // TODO: Actually use a different API here - return this.addMsisdn(phoneCountry, phoneNumber); + if (await MatrixClientPeg.get().doesServerSupportSeparateAddAndBind()) { + // For separate bind, request a token directly from the IS. + const authClient = new IdentityAuthClient(); + const identityAccessToken = await authClient.getAccessToken(); + return MatrixClientPeg.get().requestMsisdnToken( + phoneCountry, phoneNumber, this.clientSecret, 1, + undefined, undefined, identityAccessToken, + ).then((res) => { + this.sessionId = res.sid; + return res; + }, function(err) { + if (err.errcode === 'M_THREEPID_IN_USE') { + err.message = _t('This phone number is already in use'); + } else if (err.httpStatus) { + err.message = err.message + ` (Status ${err.httpStatus})`; + } + throw err; + }); + } else { + // For tangled bind, request a token via the HS. + return this.addMsisdn(phoneCountry, phoneNumber); + } } /** @@ -189,10 +209,28 @@ export default class AddThreepid { } const identityServerDomain = MatrixClientPeg.get().idBaseUrl.split("://")[1]; - return MatrixClientPeg.get().addThreePid({ - sid: this.sessionId, - client_secret: this.clientSecret, - id_server: identityServerDomain, - }, this.bind); + if (await MatrixClientPeg.get().doesServerSupportSeparateAddAndBind()) { + if (this.bind) { + const authClient = new IdentityAuthClient(); + const identityAccessToken = await authClient.getAccessToken(); + await MatrixClientPeg.get().bindThreePid({ + sid: this.sessionId, + client_secret: this.clientSecret, + id_server: identityServerDomain, + id_access_token: identityAccessToken, + }); + } else { + await MatrixClientPeg.get().addThreePidOnly({ + sid: this.sessionId, + client_secret: this.clientSecret, + }); + } + } else { + await MatrixClientPeg.get().addThreePid({ + sid: this.sessionId, + client_secret: this.clientSecret, + id_server: identityServerDomain, + }, this.bind); + } } } diff --git a/src/components/views/settings/discovery/PhoneNumbers.js b/src/components/views/settings/discovery/PhoneNumbers.js index 3462d7a467..d6c447938d 100644 --- a/src/components/views/settings/discovery/PhoneNumbers.js +++ b/src/components/views/settings/discovery/PhoneNumbers.js @@ -56,6 +56,48 @@ export class PhoneNumber extends React.Component { } async changeBinding({ bind, label, errorTitle }) { + if (!await MatrixClientPeg.get().doesServerSupportSeparateAddAndBind()) { + return this.changeBindingTangledAddBind({ bind, label, errorTitle }); + } + + const ErrorDialog = sdk.getComponent("dialogs.ErrorDialog"); + const { medium, address } = this.props.msisdn; + + try { + if (bind) { + const task = new AddThreepid(); + this.setState({ + verifying: true, + continueDisabled: true, + addTask: task, + }); + // XXX: Sydent will accept a number without country code if you add + // a leading plus sign to a number in E.164 format (which the 3PID + // address is), but this goes against the spec. + // See https://github.com/matrix-org/matrix-doc/issues/2222 + await task.bindMsisdn(null, `+${address}`); + this.setState({ + continueDisabled: false, + }); + } else { + await MatrixClientPeg.get().unbindThreePid(medium, address); + } + this.setState({ bound: bind }); + } catch (err) { + console.error(`Unable to ${label} phone number ${address} ${err}`); + this.setState({ + verifying: false, + continueDisabled: false, + addTask: null, + }); + Modal.createTrackedDialog(`Unable to ${label} phone number`, '', ErrorDialog, { + title: errorTitle, + description: ((err && err.message) ? err.message : _t("Operation failed")), + }); + } + } + + async changeBindingTangledAddBind({ bind, label, errorTitle }) { const ErrorDialog = sdk.getComponent("dialogs.ErrorDialog"); const { medium, address } = this.props.msisdn; @@ -67,12 +109,6 @@ export class PhoneNumber extends React.Component { }); try { - // XXX: Unfortunately, at the moment we can't just bind via the HS - // in a single operation, at it will error saying the 3PID is in use - // even though it's in use by the current user. For the moment, we - // work around this by removing the 3PID from the HS and re-adding - // it with IS binding enabled. - // See https://github.com/matrix-org/matrix-doc/pull/2140/files#r311462052 await MatrixClientPeg.get().deleteThreePid(medium, address); // XXX: Sydent will accept a number without country code if you add // a leading plus sign to a number in E.164 format (which the 3PID