ZOOM shouldn't be a part of the class

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
pull/21833/head
Šimon Brandner 2021-02-25 11:19:50 +01:00
parent d0dea91e92
commit fa239e506d
No known key found for this signature in database
GPG Key ID: 9760693FDD98A790
1 changed files with 11 additions and 10 deletions

View File

@ -33,6 +33,9 @@ import SettingsStore from "../../../settings/SettingsStore";
import {formatFullDate} from "../../../DateUtils"; import {formatFullDate} from "../../../DateUtils";
import dis from '../../../dispatcher/dispatcher'; import dis from '../../../dispatcher/dispatcher';
const MIN_ZOOM = 100;
const MAX_ZOOM = 300;
export default class ImageView extends React.Component { export default class ImageView extends React.Component {
static propTypes = { static propTypes = {
src: PropTypes.string.isRequired, // the source of the image being displayed src: PropTypes.string.isRequired, // the source of the image being displayed
@ -68,8 +71,6 @@ export default class ImageView extends React.Component {
initY = 0; initY = 0;
lastX = 0; lastX = 0;
lastY = 0; lastY = 0;
minZoom = 100;
maxZoom = 300;
componentDidMount() { componentDidMount() {
// We have to use addEventListener() because the listener // We have to use addEventListener() because the listener
@ -94,16 +95,16 @@ export default class ImageView extends React.Component {
ev.preventDefault(); ev.preventDefault();
const newZoom =this.state.zoom - ev.deltaY; const newZoom =this.state.zoom - ev.deltaY;
if (newZoom <= this.minZoom) { if (newZoom <= MIN_ZOOM) {
this.setState({ this.setState({
zoom: this.minZoom, zoom: MIN_ZOOM,
translationX: 0, translationX: 0,
translationY: 0, translationY: 0,
}); });
return; return;
} }
if (newZoom >= this.maxZoom) { if (newZoom >= MAX_ZOOM) {
this.setState({zoom: this.maxZoom}); this.setState({zoom: MAX_ZOOM});
return; return;
} }
@ -146,8 +147,8 @@ export default class ImageView extends React.Component {
}; };
onZoomInClick = (ev) => { onZoomInClick = (ev) => {
if (this.state.zoom >= this.maxZoom) { if (this.state.zoom >= MAX_ZOOM) {
this.setState({zoom: this.maxZoom}); this.setState({zoom: MAX_ZOOM});
return; return;
} }
@ -157,9 +158,9 @@ export default class ImageView extends React.Component {
}; };
onZoomOutClick = (ev) => { onZoomOutClick = (ev) => {
if (this.state.zoom <= this.minZoom) { if (this.state.zoom <= MIN_ZOOM) {
this.setState({ this.setState({
zoom: this.minZoom, zoom: MIN_ZOOM,
translationX: 0, translationX: 0,
translationY: 0, translationY: 0,
}); });