3a360b91b9
Update logging for unmanaged widgets, and add TODO comments for other areas
...
Just a minor thing that is bothersome. Renaming classes and functions is a bit more of an impact than is worth right now, so have settled for littering TODO comments all over the place.
2020-04-22 00:34:08 -06:00
d851f2e45f
Fix OpenID requests from widgets
...
Fixes https://github.com/vector-im/riot-web/issues/13131
Widgets can request an OpenID token to authenticate the user when the widget is missing authentication information. A common case for this is the Dimension sticker picker: sometimes the Riot is running in doesn't have the configuration to match the Dimension instance, so Riot rightly refuses to send an auth token to the widget. When this happens, it requests a token through postMessage().
There's a toggle on the permission dialog to remember the setting, which is the widget's security key. As an added measure, the security key generation ensures the widget URL matches as the 'remember this choice' toggle will silently work in the background, and it could be dangerous if the widget's URL changed and Riot secretly allows the widget to identify the user. This check was failing because the WidgetMessaging class was being set up with the rendered URL, which will not match the widget's URL at all. To fix this, we simply use the widget's URL to set up the messaging, which by proxy uses the right URL in calculating the security key.
2020-04-22 00:27:20 -06:00
f54e99c708
Use WidgetType more often to avoid breaking new sticker pickers
...
Turns out that setUserWidget() wasn't updated to take a real WidgetType, but the code in ScalarMessaging thought it did. This leads to integration managers trying to add sticker widgets with an object `type` rather than a string `type`, which doesn't work.
This updates other code paths which call into the various widget classes to use WidgetType more often. The actual code path for fixing widgets is resolved in WidgetUtils for the setUserWidget function body.
2020-04-21 16:01:10 -06:00
fd10ab840e
undo unrelated change
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-21 18:10:47 +01:00
65b3adfbe3
discard propTypes some more
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-21 18:08:01 +01:00
598cf21684
discard propTypes.
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-21 18:01:23 +01:00
b8dd68dda2
wait until cross-signing keys are fetched to show verify button
2020-04-21 18:36:15 +02:00
61c6c8de45
Add a back button to the devtools verifications panel
2020-04-21 16:27:31 +01:00
bf891c85e8
Enable esModuleInterop and iterate PR
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-21 10:01:05 +01:00
ce65df6a98
Merge remote-tracking branch 'origin/develop' into dbkr/create_secret_storage_handle_load_error
2020-04-21 09:40:44 +01:00
3b245ee678
add more type annotations
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-20 21:05:00 +01:00
8398e83d33
add more type annotations
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-20 20:35:57 +01:00
66d2a67142
deduplicate emojibase loading
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-20 19:17:58 +01:00
5c57b9ab9b
delint
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-20 19:04:55 +01:00
6328a60301
improve member name
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-20 19:02:27 +01:00
fced4ea51e
Convert autocomplete stuff to TypeScript
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-20 19:00:54 +01:00
58c8f2188a
Handle load error in create secret storage dialog
2020-04-20 18:10:23 +01:00
36f154f2b2
Name Jitsi correctly in args
...
Co-Authored-By: J. Ryan Stinnett <jryans@gmail.com>
2020-04-20 09:35:35 -06:00
a55698e943
Merge branch 'travis/moar-jitsi' into travis/addwidget-improvements
2020-04-20 09:22:38 -06:00
d8a5ba9b14
Merge branch 'develop' into travis/moar-jitsi
2020-04-20 09:21:48 -06:00
360be14b0e
Merge pull request #4450 from matrix-org/dbkr/devicelistener_wait_until_synced
...
Don't recheck DeviceListener until after initial sync is finished
2020-04-20 15:21:22 +01:00
30a3600874
Merge pull request #4449 from matrix-org/dbkr/buttonplaceholder_classname
...
Fix CSS class in ButtonPlaceholder
2020-04-20 14:39:20 +01:00
2546e23a3e
Don't recheck DeviceListener until after initial sync is finished
...
Each recheck caused a GET to account data to see if the master key
exists if done before the initial sync, which is unnecessary here.
This just makes it wait until the initial sync is done to recheck.
Fixes https://github.com/vector-im/riot-web/issues/13279
2020-04-20 14:36:15 +01:00
50cc44f0c4
Fix CSS class in ButtonPlaceholder
2020-04-20 14:16:34 +01:00
ccc1f1fe37
Merge pull request #4441 from matrix-org/t3chguy/login-tab
...
Password Login make sure tab takes user to password field
2020-04-20 13:57:52 +01:00
62763650d1
Merge pull request #4443 from matrix-org/t3chguy/cmd_rageshake
...
Add slash command to send a rageshake
2020-04-20 13:51:48 +01:00
3781bdc975
EventIndex: Add a missing semicolon.
2020-04-20 10:10:16 +02:00
6084c08f34
EventIndex: Filter out events that don't have a propper content value.
2020-04-20 10:05:04 +02:00
972baa881b
Revert "Fix Filepanel scroll position state lost when room is changed"
2020-04-19 19:14:08 -06:00
881848b98b
Add modal to confirm that rageshake from cmd was sent
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-19 12:19:31 +01:00
d0410ade5e
i18n
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-19 12:11:40 +01:00
170d10a1a6
Add rageshake slash command
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-19 12:09:07 +01:00
3bc5a0a0b2
Convert submit-rageshake to typescript
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-19 12:06:56 +01:00
7fe8894c51
Update seshat copy to remove trailing full stop
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-18 23:16:40 +01:00
b86b42c89f
Password Login make sure tab takes user to password field
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-18 16:18:01 +01:00
9e7b843f5d
Merge pull request #4388 from ThobyV/thobyv/make-filepanel-remember-scroll-position
...
Fix Filepanel scroll position state lost when room is changed
2020-04-17 15:24:52 -06:00
e0d6fa3f51
Rename ref to timelinePanel
2020-04-17 15:15:51 -06:00
d910eb4d57
Merge branch 'develop' into thobyv/make-filepanel-remember-scroll-position
2020-04-17 15:10:12 -06:00
e72008d7f1
Fix end-to-end tests for end-to-end encryption verification
...
Fixes https://github.com/vector-im/riot-web/issues/13226
This isn't the fastest route, but it is a predictable route for the happy path we probably want to test. For example, Alice will already be staring at the DM and could easily accept the verification there, but we probably want to make sure that the toast is present and does the right thing. Similarly, neither of them need to verify that there's green shields everywhere, they should be implied, however an explicit check follows a real user's gaze.
2020-04-17 14:31:33 -06:00
29028844f9
Merge pull request #4435 from matrix-org/t3chguy/typo1
...
Fix typo
2020-04-17 16:47:27 +01:00
518639e8b1
Fix typo
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-17 16:04:38 +01:00
e3d784816d
Merge branch 'develop' into foldleft/better-errors
2020-04-17 14:11:05 +01:00
66de06c7b9
Merge pull request #4381 from matrix-org/t3chguy/rageshake_incompatible_browser
...
Rageshake: remind user of unsupported browser and send modernizr report
2020-04-17 13:14:40 +01:00
cd65bdc799
Merge branches 'develop' and 't3chguy/user_online_dot' of github.com:matrix-org/matrix-react-sdk into t3chguy/user_online_dot
...
Conflicts:
src/components/views/rooms/RoomBreadcrumbs.js
src/components/views/rooms/RoomTile.js
2020-04-17 12:58:54 +01:00
81c7660bf5
Iterate copy
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-17 12:25:16 +01:00
a5f5f759cb
Create unencrypted rooms by default in e2e-tests
...
Otherwise the lazy loading test will try to join the room after the encrypted messages have already been sent, making them invisible.
See https://github.com/vector-im/riot-web/issues/13226#issuecomment-614928362
2020-04-16 16:27:43 -06:00
9e18dbc0dc
Fix key backup debug panel
...
The type changed so it thought it was not stored when it was
2020-04-16 21:08:14 +01:00
25fa675f88
Blind attempt at fixing the end to end tests
2020-04-16 11:46:29 -06:00
0fcaaab1d0
Appease the linter
2020-04-16 11:18:54 -06:00
54f8ba4d80
Remove UI to change the cross-signing setting
2020-04-16 11:15:12 -06:00
b5130ca5dc
Clean up setting definition to follow surrounding practices
...
It's not perfect, but we're at least okay with it.
2020-04-16 11:12:47 -06:00
db749519e7
Merge branch 'develop' into travis/cross-sign-setting
2020-04-16 11:06:26 -06:00
aa5573694e
Merge pull request #4428 from matrix-org/t3chguy/kegan_1
...
Make RoomPublishSetting import-skinnable
2020-04-16 17:26:01 +01:00
e1e65a0fe1
Make RoomPublishSetting import-skinnable
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-16 17:13:33 +01:00
94ace258f3
Merge pull request #4425 from matrix-org/t3chguy/recovery_copy
...
Iterate cross-signing copy
2020-04-16 15:31:35 +01:00
aea7ede7d0
update PHASE_PASSPHRASE copy
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-16 14:55:43 +01:00
e942a35525
Fixxy
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-16 14:09:41 +01:00
af59c1b5b3
iterate copy some more
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-16 14:02:32 +01:00
8c8509a603
i18n
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-16 13:48:52 +01:00
9ec8fda1ce
update Create SSSS Dialog copy
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-16 13:34:18 +01:00
ce78e3b8d8
further tweaks by Matthew
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-16 13:28:12 +01:00
1fb0f39c84
Replace `Verify this session` and `Complete security`
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-16 13:23:01 +01:00
f65c31383d
Copy tweaks with Nad
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-16 12:52:35 +01:00
a9a2999ccc
Use `recovery passphrase` and `recovery key` everywhere
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-16 12:26:12 +01:00
3933c4c31c
ensure twemoji font is loaded when showing SAS emojis
2020-04-16 11:35:54 +02:00
33391a3110
Revert "Fix: load Twemoji before login so complete security gets the right emojis during SAS"
2020-04-16 09:25:18 +00:00
c396950ca4
Merge pull request #4419 from matrix-org/bwindels/loadtwemojiearlier
...
Fix: load Twemoji before login so complete security gets the right emojis during SAS
2020-04-16 09:15:24 +00:00
135cecbd4f
Merge pull request #4410 from matrix-org/t3chguy/copy
...
consolidate and fix copy to clipboard
2020-04-16 09:47:24 +01:00
15075e4c10
load twemoji in matrixclient rather than loggedinview
2020-04-16 10:40:09 +02:00
b4e2daaf46
Convert cross-signing feature flag to setting
...
This is intended as a temporary measure until we're comfortable with removing the flag entirely.
2020-04-15 13:18:42 -06:00
a37ecbbb34
update console.error
2020-04-15 19:24:33 +01:00
2929bcf998
Merge pull request #4411 from matrix-org/t3chguy/backslash
...
Fix pills being broken by unescaped characters
2020-04-15 19:23:28 +01:00
4154acc9dd
Merge pull request #4415 from matrix-org/t3chguy/wait4initialsync
...
null-guard MatrixClientPeg in RoomViewStore
2020-04-15 18:46:23 +01:00
09e247b4f8
Merge pull request #4414 from matrix-org/bwindels/fixindexernotifs
...
Fix: prevent spurious notifications from indexer
2020-04-15 16:50:38 +00:00
49e1e6e59f
null-guard MatrixClientPeg in RoomViewStore
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-15 17:31:45 +01:00
8c2c777e2b
disable reemitting on the client for events mapped from the indexer
2020-04-15 17:37:32 +02:00
f4c4fe7d12
Merge pull request #4413 from matrix-org/t3chguy/wait4initialsync
...
Login block on initialSync with spinners
2020-04-15 16:17:13 +01:00
81f501e844
disable language dropdown too
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-15 14:19:47 +01:00
7efbae0470
Merge pull request #4408 from matrix-org/t3chguy/fix_network_dropdown_scrolling
...
Allow network dropdown to be scrollable and fix context menu padding calc
2020-04-15 14:08:34 +01:00
ac26719b69
disable password reset button when spinning
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-15 14:07:37 +01:00
fafe57624c
Merge pull request #4412 from matrix-org/jryans/hide-e2e-info-opt
...
Remove end-to-end message info option when cross-signing is used
2020-04-15 14:07:22 +01:00
8b25223026
fix onLoggedIn getting called twice
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-15 13:45:12 +01:00
76ce4081cb
i18n
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-15 12:31:27 +01:00
346b2e8588
Login block on initialSync with spinners
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-15 12:21:49 +01:00
e9c755e73f
Remove end-to-end message info option when cross-signing is used
...
This end-to-end info dialog repeats info available elsewhere and has not been
updated to make sense for cross-signing, triggers old verification methods, etc.
For now, this hides the option to present a more consistent UI.
Relates to https://github.com/vector-im/riot-web/issues/11752
2020-04-15 10:25:05 +01:00
9c1939b756
match all, not just first instance of tokens to escape
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-15 02:31:30 +01:00
4454db30d6
Escape opening square bracket too
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-15 01:02:08 +01:00
cb10640eaf
detslint
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-15 00:53:35 +01:00
c72139fc3f
Convert serialize and deserialize to TypeScript
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-15 00:49:08 +01:00
95eaf94cd8
Fix pills being broken by unescaped characters
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-15 00:40:38 +01:00
276b5b874c
Convert ShareDialog to Typescript
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-15 00:22:19 +01:00
89bc3bdd5b
consolidate and extract copyPlaintext, copyNode and selectText
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-15 00:16:11 +01:00
77bdde4021
Merge branch 'travis/moar-jitsi' into travis/addwidget-improvements
2020-04-14 12:58:16 -06:00
4fe16b1b84
Merge branch 'develop' into travis/moar-jitsi
2020-04-14 12:57:28 -06:00
36fea4d487
Merge pull request #4378 from matrix-org/travis/expanding-widgets
...
Minimize widgets by default
2020-04-14 12:56:10 -06:00
f0a2f5dd4f
Merge pull request #4380 from matrix-org/travis/widget-complaints
...
Add comments to highlight where we'll need m.widget support
2020-04-14 12:55:49 -06:00
769cf1c987
Allow network dropdown to be scrollable and fix context menu window padding calc
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-14 17:34:39 +01:00
69e680da3c
Merge pull request #4407 from matrix-org/bwindels/checkifxsignisdisabledforlegacyverif
...
Fix: dont try to enable 4S if cross-signing is disabled
2020-04-14 16:12:16 +00:00
aef6687931
Merge pull request #4406 from matrix-org/bwindels/completesecuritywithoutspinner
...
Fix: don't confuse user with spinner during complete security step
2020-04-14 15:54:44 +00:00
24fe125cb6
dont try to enable 4S if cross-signing is disabled
2020-04-14 17:53:33 +02:00
Travis Ralston