0fcbe40bec
Merge pull request #4314 from matrix-org/travis/react-warnings/2-code-quality
...
Fix a number of minor code quality issues
2020-04-01 11:13:46 -06:00
3f99332f4b
Use componentDidMount in place of componentWillMount where possible
...
This fixes a common React warning we see. Most of these components should be using constructors instead, however componentDidMount is just as good (and doesn't require converting most of these).
Conversion to classes will be done in a later stage of React warning fixes.
For https://github.com/vector-im/riot-web/issues/12877
2020-03-31 14:14:17 -06:00
c86d75693b
Fix a number of minor code quality issues
...
Most of these are complaints from my IDE. Discovered by going through nearly every file looking for React warnings.
2020-03-31 14:05:56 -06:00
19aae087e0
Field: make id optional, generate one if not provided
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-03-29 22:59:15 +01:00
69389823f7
ManageEventIndexDialog: Reword and move the crawler state around a bit.
...
This reflects now the latests design on Figma.
2020-03-06 16:07:10 +01:00
364899b27d
ManageEventIndexDialog: Show how many rooms are done instead being processed.
2020-03-06 15:44:23 +01:00
bff3f3e632
Revert "ManageEventIndexDialog: Reword the status for the currently indexing rooms."
...
This reverts commit 7d6569a0b87c48733dbddec3c2662325977d0234.
2020-03-06 15:44:23 +01:00
8fe54e5dca
ManageEventIndexDialog: Reword the status for the currently indexing rooms.
2020-03-06 15:44:23 +01:00
81e61d6f9d
EventIndexPanel: Move the comments around for the getStats calls.
2020-02-20 14:46:10 +01:00
a650c47d6b
ManageEventIndexDialog: Add a space before the function parenthesis.
2020-02-20 14:46:10 +01:00
1897d67818
EventIndexPanel: Catch getStats failures.
...
Getting the stats can fail when used with Seshat. Tantivy periodically
garbage collects its files. Smaller files are merged and the old ones
are removed.
If garbage collection occurs while we try to get the stats, which go
trough the files and figure out their sizes, we can end up trying to
figure out the file size of a removed file. The getStats call will fail
in this case but we can ignore the failure since we will likely get a
nice result next time we try.
2020-02-20 14:46:10 +01:00
9e3b0fdf7c
EventIndexPanel: Fix the removal of the updateCurrentRoom listeners.
...
The event listeners that update the current room and try to get the
current stats from the event index don't seem to be unmounted because
this != this confusion.
Turning them into arrow methods of the react class fixes this.
2020-02-20 14:46:10 +01:00
16bbea0b59
Fix various leaks due to method re-binding
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-02-20 02:35:30 +00:00
b92fe59436
Improve event indexing status strings for translation
...
The strings used for the count of rooms was hard to translate, so this adds a
bit more context.
2020-02-04 23:09:49 +00:00
d8576f23de
ManageEventINdexDialog: Fix a line length issue.
2020-02-01 12:11:49 +01:00
75fe3c2219
ManageEventIndexDialog: Show how many rooms are being currently crawled.
2020-02-01 12:01:53 +01:00
01c1c2364b
ManageEventIndexDialog: Add back a control for the crawler sleep time.
2020-01-31 18:46:45 +01:00
e38f1191a5
ManageEventIndex: Clarify that we're currently not downloading any messages.
2020-01-27 15:51:19 +01:00
9f3e5ab1db
ManageEventIndexDialog: Remove an unused import.
2020-01-24 16:52:26 +01:00
3208ac60c7
ManageEventIndexDialog: Override the Disable button class to be danger.
2020-01-24 16:47:29 +01:00
ddea7415c7
EventIndexPanel: Use formatCountLong to format the event and room counts.
2020-01-24 16:15:06 +01:00
128c0b7300
ManageEventIndexDialog: Use formatCount to format the message and room count.
2020-01-24 11:11:53 +01:00
71024d1418
ManageEventIndexDialog: Properly indent the content of the BaseDialog.
2020-01-24 11:03:40 +01:00
93facca479
ManageEventIndex: Rename the file to contain the Dialog suffix.
2020-01-24 09:54:46 +01:00
Travis Ralston