Commit Graph

9666 Commits (70bc405b6f3b5a6b8e987df470ea8f89ac5596a3)

Author SHA1 Message Date
Bruno Windels 2350d102e3 update phase when request prop changes 2020-02-24 13:39:20 +01:00
J. Ryan Stinnett 8e39bd8885 Remove unused CIDER setting watcher
This setting watcher for CIDER seems unused and logs a warning at the moment, so
this change removes it.
2020-02-24 12:36:25 +00:00
Bruno Windels dc85346e5c
Merge pull request #4102 from matrix-org/bwindels/aliasautocomplete
Use alt_aliases for pills and autocomplete
2020-02-24 12:18:07 +00:00
J. Ryan Stinnett c0c22ba7f9
Merge pull request #4108 from matrix-org/jryans/a11y-editor-keyboard
Add shortcuts for beginning / end of composer
2020-02-24 12:02:03 +00:00
Zoe af514385b2 Avoid shadowing window.setTimeout 2020-02-24 11:53:12 +00:00
Zoe 71bdc5987b added clarifying comment 2020-02-24 11:33:49 +00:00
Zoe 0663ab3b87 lint, and detect new requests 2020-02-24 10:17:33 +00:00
Michael Telatynski 0bcdf062a3 reset opener when using window.open
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-02-23 22:22:12 +00:00
Michael Telatynski b2c1242207 delint
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-02-23 22:19:18 +00:00
Michael Telatynski d783ce86c8 Use noreferrer in addition to noopener for edge case browsers
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-02-23 22:14:29 +00:00
Michael Telatynski d89b8b5148 Fix downloading files in electron not being sent into browser
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-02-23 22:10:36 +00:00
Michael Telatynski 3308152439 Fix a couple of React warnings/errors
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-02-23 14:10:41 +00:00
Matthew Hodgson 7696f704b2 Fix two big DOM leaks which were locking Chrome solid.
pillifyLinks leaked Pill components, which if they contained a BaseAvatar
would leak a whole DOM tree retained by the BaseAvatar's onClientSync
event listener.  This tracks the Pill containers so they can be unmounted
via unmountPills.

BasicMessageComposer set an event listener on selectionchange in onFocus
which leaked if onBlur wasn't called.  This removes it in unmount.

We've also seen Velociraptor retaining full DOM trees from RRs, which
this doesn't address as the leak is probably within Velocity, and the plan
is to replace it with CSS animations.

Should fix https://github.com/vector-im/riot-web/issues/12417
2020-02-22 23:51:30 +00:00
Travis Ralston c906b9eccf Filter out empty strings when pasting IDs into the invite dialog
Fixes https://github.com/vector-im/riot-web/issues/12459
2020-02-21 13:26:37 -07:00
J. Ryan Stinnett dc6a4854ce Add shortcuts for beginning / end of composer
This adds Ctrl/Command+Home/End shortcuts for jumping to the start and end of
the composer contents.

Fixes https://github.com/vector-im/riot-web/issues/12438
2020-02-21 18:50:44 +00:00
Zoe 72789897a0 Quick n dirty verificatio request viewer in devtools 2020-02-21 17:15:53 +00:00
Travis Ralston f74b283287
Merge pull request #4091 from matrix-org/travis/qr-binary
Use binary packing for verification QR codes
2020-02-21 10:05:12 -07:00
Travis Ralston 4de2fdc5c3
Merge pull request #4099 from matrix-org/travis/invite-fixes
Fix several small bugs with the invite/DM dialog
2020-02-21 09:24:53 -07:00
Michael Telatynski 4ed4d91b48 move to a more reusable code path
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-02-21 14:54:56 +00:00
Michael Telatynski b77c2df2be Fix theme being overridden to light even after login is completed
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-02-21 14:40:42 +00:00
Bruno Windels 07d24038a3 fix lint 2020-02-21 14:11:30 +01:00
Bruno Windels fada013f9e this isn't doing anything because we don't have a room when the alias is not moderated 2020-02-21 14:06:57 +01:00
Bruno Windels 3c3839f863 show a pill as a moderated alias (canonical or alt) if available
otherwise, display as the label in the link
2020-02-21 13:02:41 +01:00
Bruno Windels 4219d2fcf6 style a room pill even if we don't find the room 2020-02-21 13:02:41 +01:00
Bruno Windels f6313b51e6 also look in alt_aliases to match a pill to a room 2020-02-21 13:02:41 +01:00
Michael Telatynski e6d8c4a576 Merge branches 'develop' and 't3chguy/alpha_room_list' of github.com:matrix-org/matrix-react-sdk into t3chguy/alpha_room_list 2020-02-21 11:18:45 +00:00
Zoe 7d319bab7f fix ssss overwrite 2020-02-21 10:18:47 +00:00
Travis Ralston bcb1d73c3c Appease the linter 2020-02-20 23:21:35 -07:00
Travis Ralston 8ba274a382 Allow creating a room with only yourself in it
Fixes https://github.com/vector-im/riot-web/issues/12092
2020-02-20 23:16:21 -07:00
Travis Ralston f491e4222a Convert the user's last filter into a selection if possible
Fixes https://github.com/vector-im/riot-web/issues/12440
2020-02-20 23:10:43 -07:00
Travis Ralston 62aaa0db9a Always insert suggestions for user IDs
Fixes https://github.com/vector-im/riot-web/issues/12419
2020-02-20 23:02:10 -07:00
Travis Ralston 00cc253594 Always suggest a pill for MXID-looking users
Part of https://github.com/vector-im/riot-web/issues/12440
2020-02-20 23:02:10 -07:00
Bruno Windels 744826db48
Merge pull request #4096 from matrix-org/bwindels/canonicalpill
Accept canonical alias for pills
2020-02-20 17:07:54 +00:00
Bruno Windels d324dfaceb
Merge pull request #4094 from matrix-org/bwindels/dontsaywecanscan
Fix: don't advertise ability to scan a QR code for verification
2020-02-20 16:44:27 +00:00
Bruno Windels fee9c7d21f accept canonical alias for pills 2020-02-20 17:43:33 +01:00
Damir Jelić 81e61d6f9d EventIndexPanel: Move the comments around for the getStats calls. 2020-02-20 14:46:10 +01:00
Damir Jelić 1897d67818 EventIndexPanel: Catch getStats failures.
Getting the stats can fail when used with Seshat. Tantivy periodically
garbage collects its files. Smaller files are merged and the old ones
are removed.

If garbage collection occurs while we try to get the stats, which go
trough the files and figure out their sizes, we can end up trying to
figure out the file size of a removed file. The getStats call will fail
in this case but we can ignore the failure since we will likely get a
nice result next time we try.
2020-02-20 14:46:10 +01:00
Michael Telatynski b1a3d8ad63
Merge pull request #4092 from matrix-org/t3chguy/persist
Use Persistent Storage where possible
2020-02-20 11:56:54 +00:00
Bruno Windels fb28bbbaa6 dont say we can scan when we dont 2020-02-20 12:06:34 +01:00
Bruno Windels 86c871f55f
Merge pull request #4088 from matrix-org/bwindels/fixuserpage
Fix user page (missing null check)
2020-02-20 11:01:15 +00:00
Bruno Windels 913caf67a9
Merge pull request #4081 from matrix-org/bwindels/cancelondialogclose
Cancel verification request on dialog close
2020-02-20 11:00:00 +00:00
Michael Telatynski 16bbea0b59 Fix various leaks due to method re-binding
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-02-20 02:35:30 +00:00
Michael Telatynski ffde11ca91 Use Persistent Storage where possible
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-02-20 00:38:08 +00:00
Travis Ralston 760a472be5 Appease the linter 2020-02-19 17:05:32 -07:00
Travis Ralston 3b6a201d4e Add comments 2020-02-19 17:03:50 -07:00
Travis Ralston 45963adeb4 Use binary packing for verification QR codes
Fixes https://github.com/vector-im/riot-web/issues/12257
Fixes https://github.com/vector-im/riot-web/issues/12375

We do not remove the existing QR code library in this commit because it is still used elsewhere (like the share dialog). 

This should be as accurate as possible to what [MSC1543](https://github.com/matrix-org/matrix-doc/pull/1544) asks for.
2020-02-19 17:02:14 -07:00
Michael Telatynski 12eb408c58
Merge pull request #4073 from matrix-org/t3chguy/a11y_share_msg
Fix share message context menu option keyboard a11y
2020-02-19 17:41:28 +00:00
Michael Telatynski a6edc34e97 Iterate things
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-02-19 14:52:00 +00:00
Bruno Windels a5b9682572 show spinner while loading local aliases 2020-02-19 15:15:05 +01:00
Michael Telatynski 4278d44059 Merge branches 'develop' and 't3chguy/alpha_room_list' of github.com:matrix-org/matrix-react-sdk into t3chguy/alpha_room_list 2020-02-19 13:30:47 +00:00
Michael Telatynski b1b17a313e
Merge pull request #4046 from matrix-org/t3chguy/usercontent
Get rid of dependence on usercontent.riot.im
2020-02-19 12:53:01 +00:00
Bruno Windels 30ae6dbdbb also detect aliases using new /aliases endpoint for room access settings 2020-02-19 11:18:56 +01:00
Bruno Windels cb5882d59b add null check 2020-02-19 10:40:00 +01:00
Bruno Windels 4c9c57bfe5 check server feature flag
if not available, revert to old behavior
2020-02-19 10:06:52 +01:00
Bruno Windels e6ca581f10 get local aliases from /aliases in room settings 2020-02-18 16:27:45 +01:00
Michael Telatynski 600cb64d00 don't nest <a> inside <AccessibleButton>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-02-18 15:04:57 +00:00
Michael Telatynski 932c9b3106 First attempt alpha room list sorting
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-02-18 14:55:12 +00:00
Zoe 27f65c17b5
Merge pull request #4080 from matrix-org/foldleft/12187-e2e-dm
Start verification sessions in an E2E DM where possible
2020-02-18 13:53:56 +00:00
Zoe 0e0aadd3f2 fixed inexplicible scope bug 2020-02-18 11:30:10 +00:00
Zoe 164b355ffe abstract out the check for available target devices 2020-02-18 11:25:19 +00:00
Bruno Windels 1b38827d92
Merge pull request #4077 from matrix-org/bwindels/filterverifmethods
Only show supported verification methods
2020-02-18 10:16:01 +00:00
Bruno Windels 46e63fd571 cancel on dialog close 2020-02-18 11:14:16 +01:00
Bruno Windels 05403eb98c
Merge pull request #4072 from matrix-org/bwindels/localecho2
Use local echo in VerificationRequest for accepting/declining a verification request
2020-02-18 09:55:27 +00:00
Hubert Chathi 4a204b715d
Merge pull request #4059 from matrix-org/uhoreg/refactor_event_grouping
refactor event grouping into separate helper classes
2020-02-14 10:35:34 -05:00
Bruno Windels 93674ec781
Merge pull request #4070 from matrix-org/bwindels/oneverifrequest
Find existing requests when starting a new verification request
2020-02-14 15:33:27 +00:00
Bruno Windels 30718e7fde unsent could potentially also happen here
although should not happen in practice
2020-02-14 13:48:38 +01:00
Bruno Windels a6c072ab42 only show supported verification methods
also an error message if none match
2020-02-14 13:48:18 +01:00
Michael Telatynski 8087f18bf7 Remove unused props
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-02-14 10:32:42 +00:00
Marco Zehe b83bc7db68 Always speak the full text of the typing indicator when it updates.
By default, aria-live regions only speak partial updates. However in the case of the typing indicator, if it goes from one person typing to several, and back, the updated text would only be spoken in fragments by screen readers. Adding the aria-atomic attribute with a value of true makes screen readers always speak the full update for this tile, making the experience much nicer.

Signed-off-by: Marco Zehe <marcozehe@mailbox.org>
2020-02-14 11:12:41 +01:00
Michael Telatynski 42b63fbc81 Fix share message context menu option keyboard a11y
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-02-14 09:36:10 +00:00
Michael Telatynski 256659e6f8
Merge pull request #4071 from MarcoZehe/MoveSidebarTabs
Move the sidebar to below the sidebar tab buttons for screen readers.
2020-02-13 18:31:25 +00:00
Marco Zehe 7840aa74fd Fix ID to be namespaced
Signed-off-by: Marco Zehe <marcozehe@mailbox.org>
2020-02-13 19:18:21 +01:00
Michael Telatynski 627a4d4ea4 Update comments and such
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-02-13 16:53:45 +00:00
Michael Telatynski 12aae12218 Merge branches 'develop' and 't3chguy/usercontent' of github.com:matrix-org/matrix-react-sdk into t3chguy/usercontent 2020-02-13 16:36:05 +00:00
Bruno Windels 3292991491 provide specific label for when accepting/declining is in progress
also distuingish between cancelling and declining
2020-02-13 17:29:38 +01:00
Bruno Windels 3eb07465f7 use canAccept in tile, which takes local echo into account 2020-02-13 17:29:13 +01:00
Bruno Windels 3ec0301f9d use canAccept in toast, which takes local echo into account 2020-02-13 17:28:10 +01:00
Marco Zehe 6319407cab Move the sidebar to below the sidebar tab buttons for screen readers.
Do this by aria-owning the sidebar into the header wrapper. aria-owned subtrees get added as the last child after all other child elements that are in the DOM. This way, if a sidebar tab is activated, the aside element now is inserted in a position following the tabs, before the main messages list. The association for screen readers is therefore more logical. This has no bearing on the DOM order or CSS properties. aria-owns simply rearranges the accessibility tree.

Fixes vector-im/riot-web/issues/11319

Signed-off-by: Marco Zehe <marcozehe@mailbox.org>
2020-02-13 16:02:58 +01:00
Zoe 37f1104f61 lint 2020-02-13 14:15:08 +00:00
Zoe c3af1a2f95 don't be too magic about hiding tooltips 2020-02-13 13:47:39 +00:00
Bruno Windels 4b7cc12daa check if there is already a request in progress when clicking verify
and go straight there instead of first showing EncryptionInfo panel
2020-02-13 14:34:44 +01:00
Bruno Windels 68197a1d18 also update phase after starting request
as it might now be a request that is already ongoing
2020-02-13 14:33:35 +01:00
Bruno Windels d49fbf25f7 check if verifier sasEvent was already set on mount
this allow the verification panel to fully recover
the UI state from an on-going verification request
2020-02-13 14:32:33 +01:00
Zoe 9649f2a2da don't show tooltips on big icons
fixes: https://github.com/vector-im/riot-web/issues/12191
2020-02-13 10:11:57 +00:00
Bruno Windels ec708b5e9b
Merge pull request #4058 from matrix-org/bwindels/dontpassmethodstoverify
remove methods arg to requestVerification(DM)
2020-02-13 08:51:36 +00:00
Travis Ralston d172e1bf85 Revert "Merge pull request #4060 from matrix-org/travis/better-invite"
This reverts commit 48860f0a10.
2020-02-12 10:44:27 -07:00
Travis Ralston 48860f0a10
Merge pull request #4060 from matrix-org/travis/better-invite
Score user ID searches higher when they match nearly exactly
2020-02-12 10:03:33 -07:00
Zoe e1608509d0 Disable 'start' button after clicking in VerificationPanel 2020-02-12 13:53:16 +00:00
Zoe 466d4a3e51
Merge pull request #4057 from matrix-org/foldleft/12221-secret-storage
Fixed bug where key reset didn't always return the right key
2020-02-12 11:18:32 +00:00
Marco Zehe 8004a35179 Update to use proper quotes and fix code styling. And fix test.
Signed-off-by: Marco Zehe <marcozehe@mailbox.org>
2020-02-12 10:54:08 +01:00
Marco Zehe 6fe4eb1fc3 Don't render avatars in pills for screen readers.
These don't provide any additional information, but add extraneous noise. The link text and title already provide all information. Therefore, mark the avatar inside pills (the mention links inside messages) as hidden. Note that due to the images being part of something focusable, role "presentation" does not work here.

Signed-off-by: Marco Zehe <marcozehe@mailbox.org>
2020-02-12 09:36:59 +01:00
Travis Ralston 9acf70c693 Score user ID searches higher when they match nearly exactly 2020-02-12 01:55:20 +00:00
Hubert Chathi be70ef44f8 lint 2020-02-11 15:34:14 -05:00
Hubert Chathi 4c5046afd5 refactor event grouping into separate helper classes 2020-02-11 15:19:32 -05:00
Bruno Windels 33f3a61b94 remove unused imports 2020-02-11 18:23:05 +01:00
Bruno Windels a1844e44f2 remove methods arg to requestVerification(DM)
as it's easy to have this argument be out of sync from all
the places this is called from the js-sdk. There is also little point,
as you can already specify the methods a consumer of the js-sdk
wants to provide through the verificationMethods option when creating
the client object.
2020-02-11 18:22:48 +01:00
Bruno Windels 91c9c00712
Merge pull request #4044 from matrix-org/bwindels/riotx-qr-compat
Make QR self-verification compatible with RiotX
2020-02-11 17:20:40 +00:00
Zoe 5382a52519 Fixed bug where key reset didn't always return the right key 2020-02-11 15:57:14 +00:00
Bruno Windels 7a026eb15d
Merge pull request #4043 from matrix-org/bwindels/showunverifieddevicedialogonclick
Verify single device from other user in right panel & Not Trusted dialog
2020-02-11 15:35:24 +00:00
Bruno Windels 1d39aa6a81
Merge pull request #4049 from matrix-org/bwindels/verifybuttonsdisable
Disable verification buttons after clicking to avoid double submission
2020-02-11 15:35:00 +00:00