Commit Graph

47 Commits (806e146f16e1a3700c7f039f80d88f66004597c8)

Author SHA1 Message Date
Kerry 238ff8d665
Cypress flake: disable `Paging up through old messages after a room is read leaves the room read` (#11801)
* disable flaky cypress test `Paging up through old messages after a room is read leaves the room read`

* Update cypress/e2e/read-receipts/high-level.spec.ts

---------

Co-authored-by: Michael Weimann <michaelw@matrix.org>
2023-10-26 07:30:51 +00:00
Florian Duros a306a08780
Disable `After marking room as read, paging up to find old threads that were never read leaves the room read` for new crypto (#11795) 2023-10-25 09:10:21 +00:00
Andy Balaam fa559cddbe
Skip flaky test 'Looking in thread view to find old threads' (#11724) 2023-10-19 11:06:57 +00:00
Andy Balaam 73f91cbafa
Enable tests that have been fixed by matrix-js-sdk#3798 (#11762)
* Disable two tests that flake after matrix-js-sdk#3798

* Enable tests that have been fixed by matrix-js-sdk#3798

* Disable two flaking tests

* Disable another flaking test
2023-10-18 16:12:35 +00:00
Andy Balaam 94ca061cda
Disable two tests that flake after matrix-js-sdk#3798 (#11761) 2023-10-17 14:08:58 +00:00
Andy Balaam 6a9942576d
Increase the timeout for the bot to enter the room (#11742)
in an attempt to fix flakes like:

* https://github.com/vector-im/element-web/issues/26298
* https://github.com/vector-im/element-web/issues/26341

which appear to fail when using Rust crypto, possibly because the client
takes a while to start up.
2023-10-13 08:50:16 +00:00
Richard van der Hoff 7ff2b02364
Disable a bunch of flaky cypress tests (#11719) 2023-10-05 15:30:49 +01:00
Andy Balaam 11507790fd
Skip redaction tests that are still flaking (#11704)
* Unflake redaction tests by checking unread state before sending redactions

* Skip a flaky test

* Skip redaction tests that are still flaking
2023-10-03 21:12:36 +00:00
Andy Balaam 54a4875e15
Unflake redaction tests by checking unread state before sending redactions (#11696) 2023-10-03 18:03:52 +01:00
Andy Balaam ff1057fb0a Share code for room initialisation between read receipt tests 2023-10-02 16:59:38 +01:00
Andy Balaam 966d8bd695
Ensure the bot has joined the correct room before we start the test (#11693) 2023-10-02 12:51:56 +00:00
Andy Balaam 1897962086
Fix expectations in edit tests: edits should not cause unread (#11682)
* Fix expectations in edit tests: edits should not cause unread

* Skip flaky test
2023-10-02 09:55:18 +00:00
Andy Balaam 506f286a3e
Tests for paging up to find old messages (#11650)
* Use longer numbers for many() messages to avoid substring clashes

* Tests for paging up
2023-09-29 08:26:47 +00:00
Andy Balaam d7d0f54e9b
Merge branch 'develop' into andybalaam/fix-receipt-flakes 2023-09-28 14:23:45 +01:00
Andy Balaam 58afa900d5
Target specific thread name to unflake redaction tests (#11662)
* Disambiguate thread root names to unflake redaction tests

* Revert "Disambiguate thread root names to unflake redaction tests"

This reverts commit f21ffa5554e7d49322acc8f8c1c1ef4063b9efdd.

* Find thread root by text, not contains
2023-09-28 12:44:29 +00:00
Andy Balaam 8565637213
Merge branch 'develop' into andybalaam/fix-receipt-flakes 2023-09-25 17:40:08 +01:00
Andy Balaam de250df520
Merge pull request #11654 from matrix-org/andybalaam/fix-high-level-flakes
Fix flake in high-level tests by not using markAsRead
2023-09-25 12:53:56 +01:00
Andy Balaam 4804adcef6 Fix flaky receipt and redaction tests by pausing between message sends 2023-09-25 12:06:22 +01:00
Andy Balaam 4097844fed Fix flake in high-level tests by not using markAsRead 2023-09-25 09:55:37 +01:00
Andy Balaam 25a462ad8e Fix lint error 2023-09-25 09:51:44 +01:00
Andy Balaam 10eac43e24 Fix flaky test that raced because we were in the room while the count changed 2023-09-25 09:51:44 +01:00
Andy Balaam 14a622b1e8 Fix flaky test that assumes edits count as messages 2023-09-25 09:51:44 +01:00
Andy Balaam 1c2d604abe
Split the read-receipt tests into logical units (#11649)
* Split the read-receipt tests into logical units

* Move read-receipt docs into a readme file

* Provide doc comments for exported functions in read-receipt tests
2023-09-22 11:57:40 +00:00
Andy Balaam 8ac25758b3
Cypress tests for redacted messages in threads and thread roots (#11629)
* Tests for redacted messages in threads and thread roots

* Cache redacted events and enable tests that refer to them
2023-09-20 10:57:24 +00:00
Andy Balaam d46d4b3d04
More tests for reactions to messages in threads (#11612)
* Tests for redacting messages not increasing unreads

* Comment explaining tips for writing high level rr tests

* Test for restarting with a receipt pointing at a redacted thread root

* Two failing tests for counting correctly when a thread message was redacted

* Test for reading a thread containing an earlier redaction

* Failing tests for redacted messages in threads

* More tests for reactions to messages in threads

* Wait before looking for the thread list, to let the room settle
2023-09-19 13:29:04 +00:00
Andy Balaam e887c6d71f
Cypress tests for redactions in threads (#11594)
* Tests for redacting messages not increasing unreads

* Comment explaining tips for writing high level rr tests

* Test for restarting with a receipt pointing at a redacted thread root

* Two failing tests for counting correctly when a thread message was redacted

* Test for reading a thread containing an earlier redaction

* Failing tests for redacted messages in threads
2023-09-18 15:01:05 +00:00
Andy Balaam 5a3c32e26c
More assertions about threads being read (#11505) 2023-09-18 09:09:47 +00:00
Andy Balaam b1f455eb2d
Assert that the thread is unread after an edit (#11504)
* Expand a thread reply test to be more explicit

* Add an assertion that the thread is read after I read it

* Assert that the thread is unread after an edit
2023-09-12 11:41:04 +00:00
Andy Balaam a4156add49
Tests for thread roots and reading history (#11588)
* Minor improvements to unread tests

* Test for reading an older message in a room

* Test for reading an old message in a thread

Also a mostly-trivial test for read status being preserved over
restarts.

* Give the reason for a failing test

* Fix a failing test by making it wait for a thread to be read

* More tests for thread roots
2023-09-12 03:22:04 +00:00
Andy Balaam a621dfa6c1
Expand a thread reply test to be more explicit (#11502) 2023-09-09 06:45:48 +00:00
Andy Balaam a4b861637f
Avoid using markAsRead where we don't need it (#11517)
* Avoid using markAsRead where we don't need it

* Review response
2023-09-08 13:07:26 +00:00
Andy Balaam 493d5083a8
Tests for reacting to thread roots (#11586) 2023-09-08 13:06:44 +00:00
Andy Balaam 728a3a751a
Tests for redactions in the main timeline (#11587) 2023-09-08 13:06:25 +00:00
Andy Balaam 77b681eed9
Add a (failing for unrelated reasons) test for reading a thread root (#11534) 2023-09-08 00:32:16 +00:00
Andy Balaam f8ff95349a
Add a 'm.relates_to' to edits in receipt tests and disable failing tests (#11501)
* Add a 'm.relates_to' to edits in receipt tests

* Disable a test that fails with real edits

* Wait for the room to be read after we mark it as read

* Skip tests that are failing because of inconsistencies between local and CI behaviour
2023-09-04 16:08:03 +00:00
Andy Balaam c7b0850ffe
Improve comments in unread tests (#11491) 2023-08-31 13:08:37 +00:00
Andy Balaam aaea42c626
Use a single synapse for all unread tests. (#11489)
Saves about 30 seconds per run.
2023-08-30 15:15:47 +00:00
Andy Balaam 5b290196cd
Fix read receipt tests with incorrect read counts (#11465)
These counts were transiently correct if the client was slow enough, so
the tests usually passed, but actually they were wrong.
2023-08-25 09:20:43 +00:00
Michael Telatynski 99e80dd296
Consume more imports from matrix-js-sdk/src/matrix (#11449) 2023-08-23 09:04:25 +00:00
Michael Telatynski beafe686a9
Wire up more high level read receipt tests (#11408)
* Improve existing tests

* Wire up more tests

* Wire up more tests

* Wire up more tests

* Wire up more tests
2023-08-15 14:08:53 +00:00
Travis Ralston 180fcaa70f
Support Matrix 1.1 (drop legacy r0 versions) (#9819)
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
2023-08-14 09:25:13 +01:00
Andy Balaam c55400de18
Tests for read/unread status (#11301)
* Add some fantasy tests

* Turn commented code into pretend-real code

* First pass at a list of all the cases we should test

* List test cases related to redactions

* Add testcases about paging up

* Add a case about notification counts

* More test cases related to replies, notifications, room list

* Iterate tests

* Wire up additional tests

* Wire up more tests

* Tidy

* Wire up more tests

* Wire up more tests

* Wire up more tests

* Wire up more tests

* Mute browser

* Silence electron warnings

* Iterate

* revert

* Wire up more tests

* Try to stabilise tests

* Try to stabilise tests

* Validate that the notification dot is missing as well as the count

* Skip a test that is failing for unknown reasons

* Use markAsRead in 'marking as read' test and add related test

* Fix incorrect comment

* Extract tests to their own suite

* Attempt to fix test

* Wire up more tests

* Wire up more tests

* Wire up more tests

* Wire up more tests

* Iterate

* Add comments

* Iterate

* Fix comments

* Update cypress/e2e/read-receipts/high-level.spec.ts

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

---------

Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
2023-08-10 12:59:01 +00:00
Michael Telatynski 47877ba2da
Switch to importing matrix-js-sdk from its main export (#11360)
* Switch to importing TypedEventEmitter from main js-sdk export

* Switch to importing js-sdk/matrix in cypress

* Remove duplicated imports

* Fix lint:js-fix to run prettier last otherwise ESLint --fix may cause a mess

* Add lint rule

* Fix cypress-axe import

* Fix cypress-axe import
2023-08-03 12:56:30 +00:00
Michael Telatynski 19d927f497
Fix over-simplified cypress test (#11294) 2023-07-19 03:43:57 +00:00
Michael Weimann 4e5687c454
Send correct receipts when viewing a room (#10864)
* Send correct receipts when viewing a room

* Fix strict type issues

* Handle promises

* Handle more primises

* Add generic array type

* Replace existende check with type predicate

* Fix wrong variable check

* Improve comment about initial read marker

* Use read_markers API for fully read receipts

* Log public receipt fallback

* Rename variables in new code to be aligned to the spec

* Add end-2-end test for read markers and receipts
2023-05-15 16:06:02 +00:00
Andy Balaam 415fcde5e8
Cypress tests for read receipts, threaded and unthreaded (#10872) 2023-05-12 08:04:33 +00:00
Andy Balaam d494b45910
Test for element-web#24629 - read receipts on main and unthreaded don't clash (#10769) 2023-05-03 11:13:46 +00:00