Commit Graph

17379 Commits (d89b8b51484c68c6fe0b1325b5d59ee809cc2196)

Author SHA1 Message Date
Michael Telatynski d89b8b5148 Fix downloading files in electron not being sent into browser
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-02-23 22:10:36 +00:00
Matthew Hodgson 7696f704b2 Fix two big DOM leaks which were locking Chrome solid.
pillifyLinks leaked Pill components, which if they contained a BaseAvatar
would leak a whole DOM tree retained by the BaseAvatar's onClientSync
event listener.  This tracks the Pill containers so they can be unmounted
via unmountPills.

BasicMessageComposer set an event listener on selectionchange in onFocus
which leaked if onBlur wasn't called.  This removes it in unmount.

We've also seen Velociraptor retaining full DOM trees from RRs, which
this doesn't address as the leak is probably within Velocity, and the plan
is to replace it with CSS animations.

Should fix https://github.com/vector-im/riot-web/issues/12417
2020-02-22 23:51:30 +00:00
Travis Ralston c906b9eccf Filter out empty strings when pasting IDs into the invite dialog
Fixes https://github.com/vector-im/riot-web/issues/12459
2020-02-21 13:26:37 -07:00
Travis Ralston f74b283287
Merge pull request #4091 from matrix-org/travis/qr-binary
Use binary packing for verification QR codes
2020-02-21 10:05:12 -07:00
Travis Ralston 4de2fdc5c3
Merge pull request #4099 from matrix-org/travis/invite-fixes
Fix several small bugs with the invite/DM dialog
2020-02-21 09:24:53 -07:00
Michael Telatynski 7add51e3e8
Merge pull request #4104 from matrix-org/t3chguy/null-guard-room-pills
Apply null-guard to room pills for when we can't fetch the room
2020-02-21 15:38:08 +00:00
Michael Telatynski 476c622a61
Merge pull request #4105 from matrix-org/t3chguy/fix_theme
Fix theme being overridden to light even after login is completed
2020-02-21 15:37:44 +00:00
Hubert Chathi 953af6f036
add device and cross-signing public keys to rageshake info (#4097) 2020-02-21 10:19:53 -05:00
Michael Telatynski 4ed4d91b48 move to a more reusable code path
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-02-21 14:54:56 +00:00
Michael Telatynski b77c2df2be Fix theme being overridden to light even after login is completed
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-02-21 14:40:42 +00:00
Michael Telatynski e799691573 Apply null-guard to room pills for when we can't fetch the room
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-02-21 14:14:24 +00:00
Zoe 7d319bab7f fix ssss overwrite 2020-02-21 10:18:47 +00:00
Travis Ralston bcb1d73c3c Appease the linter 2020-02-20 23:21:35 -07:00
Travis Ralston 8ba274a382 Allow creating a room with only yourself in it
Fixes https://github.com/vector-im/riot-web/issues/12092
2020-02-20 23:16:21 -07:00
Travis Ralston f491e4222a Convert the user's last filter into a selection if possible
Fixes https://github.com/vector-im/riot-web/issues/12440
2020-02-20 23:10:43 -07:00
Travis Ralston 62aaa0db9a Always insert suggestions for user IDs
Fixes https://github.com/vector-im/riot-web/issues/12419
2020-02-20 23:02:10 -07:00
Travis Ralston 00cc253594 Always suggest a pill for MXID-looking users
Part of https://github.com/vector-im/riot-web/issues/12440
2020-02-20 23:02:10 -07:00
Bruno Windels 744826db48
Merge pull request #4096 from matrix-org/bwindels/canonicalpill
Accept canonical alias for pills
2020-02-20 17:07:54 +00:00
Bruno Windels d324dfaceb
Merge pull request #4094 from matrix-org/bwindels/dontsaywecanscan
Fix: don't advertise ability to scan a QR code for verification
2020-02-20 16:44:27 +00:00
Bruno Windels fee9c7d21f accept canonical alias for pills 2020-02-20 17:43:33 +01:00
Damir Jelić 81e61d6f9d EventIndexPanel: Move the comments around for the getStats calls. 2020-02-20 14:46:10 +01:00
Damir Jelić a650c47d6b ManageEventIndexDialog: Add a space before the function parenthesis. 2020-02-20 14:46:10 +01:00
Damir Jelić 1897d67818 EventIndexPanel: Catch getStats failures.
Getting the stats can fail when used with Seshat. Tantivy periodically
garbage collects its files. Smaller files are merged and the old ones
are removed.

If garbage collection occurs while we try to get the stats, which go
trough the files and figure out their sizes, we can end up trying to
figure out the file size of a removed file. The getStats call will fail
in this case but we can ignore the failure since we will likely get a
nice result next time we try.
2020-02-20 14:46:10 +01:00
Damir Jelić 9e3b0fdf7c EventIndexPanel: Fix the removal of the updateCurrentRoom listeners.
The event listeners that update the current room and try to get the
current stats from the event index don't seem to be unmounted because
this != this confusion.

Turning them into arrow methods of the react class fixes this.
2020-02-20 14:46:10 +01:00
Michael Telatynski b1a3d8ad63
Merge pull request #4092 from matrix-org/t3chguy/persist
Use Persistent Storage where possible
2020-02-20 11:56:54 +00:00
Bruno Windels fb28bbbaa6 dont say we can scan when we dont 2020-02-20 12:06:34 +01:00
Bruno Windels 86c871f55f
Merge pull request #4088 from matrix-org/bwindels/fixuserpage
Fix user page (missing null check)
2020-02-20 11:01:15 +00:00
Bruno Windels 913caf67a9
Merge pull request #4081 from matrix-org/bwindels/cancelondialogclose
Cancel verification request on dialog close
2020-02-20 11:00:00 +00:00
Michael Telatynski 16bbea0b59 Fix various leaks due to method re-binding
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-02-20 02:35:30 +00:00
Michael Telatynski ffde11ca91 Use Persistent Storage where possible
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-02-20 00:38:08 +00:00
Travis Ralston 760a472be5 Appease the linter 2020-02-19 17:05:32 -07:00
Travis Ralston 3b6a201d4e Add comments 2020-02-19 17:03:50 -07:00
Travis Ralston 45963adeb4 Use binary packing for verification QR codes
Fixes https://github.com/vector-im/riot-web/issues/12257
Fixes https://github.com/vector-im/riot-web/issues/12375

We do not remove the existing QR code library in this commit because it is still used elsewhere (like the share dialog). 

This should be as accurate as possible to what [MSC1543](https://github.com/matrix-org/matrix-doc/pull/1544) asks for.
2020-02-19 17:02:14 -07:00
Michael Telatynski 12eb408c58
Merge pull request #4073 from matrix-org/t3chguy/a11y_share_msg
Fix share message context menu option keyboard a11y
2020-02-19 17:41:28 +00:00
Bruno Windels a5b9682572 show spinner while loading local aliases 2020-02-19 15:15:05 +01:00
Damir Jelić 7f71e551da EventIndex: Split out the statements that check for a valid event type. 2020-02-19 14:50:59 +01:00
Damir Jelić 156c6b8db8 EventIndex: Document the return value of the isValidEvent method. 2020-02-19 14:50:59 +01:00
Damir Jelić 59f8b4f6b1 EventIndex: Don't index key verification events.
Since cross-signing is a thing key verification events have become part
of the timeline and room history.

Those events are m.room.message events for backwards compatibility, so
clients that don't support key verification in the timeline print out a
fall-back message.
2020-02-19 14:50:59 +01:00
Michael Telatynski b1b17a313e
Merge pull request #4046 from matrix-org/t3chguy/usercontent
Get rid of dependence on usercontent.riot.im
2020-02-19 12:53:01 +00:00
Michael Telatynski 4da5f32764 get rid of lockOrigin backwards compatibility
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-02-19 12:44:46 +00:00
Bruno Windels 30ae6dbdbb also detect aliases using new /aliases endpoint for room access settings 2020-02-19 11:18:56 +01:00
Bruno Windels cb5882d59b add null check 2020-02-19 10:40:00 +01:00
Bruno Windels 4c9c57bfe5 check server feature flag
if not available, revert to old behavior
2020-02-19 10:06:52 +01:00
Bruno Windels e6ca581f10 get local aliases from /aliases in room settings 2020-02-18 16:27:45 +01:00
Michael Telatynski 600cb64d00 don't nest <a> inside <AccessibleButton>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-02-18 15:04:57 +00:00
Zoe 27f65c17b5
Merge pull request #4080 from matrix-org/foldleft/12187-e2e-dm
Start verification sessions in an E2E DM where possible
2020-02-18 13:53:56 +00:00
Zoe 0e0aadd3f2 fixed inexplicible scope bug 2020-02-18 11:30:10 +00:00
Zoe 164b355ffe abstract out the check for available target devices 2020-02-18 11:25:19 +00:00
Bruno Windels 1b38827d92
Merge pull request #4077 from matrix-org/bwindels/filterverifmethods
Only show supported verification methods
2020-02-18 10:16:01 +00:00
Bruno Windels 46e63fd571 cancel on dialog close 2020-02-18 11:14:16 +01:00