Sometimes, when I ran these tests locally, they would fail. The problem appears
to be that the join takes some time and can end up racing against the body of
the test. The solution is to wait for the join to complete before proceeding.
* Minimum hacks required to run cypress tests with dendrite
* Remove wget hack since dendrite containers now have curl
* Add basic dendritedocker plugin & hack into login spec for testing
* Add generic HomeserverInstance interface
* Add env var to configure which homeserver to use
* Remove synapse specific homeserver support api
* Update the rest of the tests to use HomeserverInstance
* Update cypress docs to reference new homeserver abstraction
* Fix formatting issues
* Change dendrite to use main branch container
* Add safety to the spotlight search dialog
Fixes https://github.com/vector-im/element-web/issues/22851
This test was triggering the mentioned bug only occasionally because it was dependent on when the search settled: if it settled early then the length was wrong. In testing, the dialog was caught multiple times to have passed the length chat but update to show duplicated results before the test closed the client, indicating a race condition within the tests.
To fix this, we just make sure everything settles before moving on. We do this on unaffected tests too to ensure they don't regress later.
The affected test was "should find group DMs by usernames or user ids".
* Update cypress/e2e/spotlight/spotlight.spec.ts
Co-authored-by: Robin <robin@robin.town>
Co-authored-by: Robin <robin@robin.town>
Richard van der Hoff