element-web/res/css/components/views/location
Suguru Hirahara abfc66a34e
Improve _ShareType.scss (#8737)
* Specify the button style explicitly removing the dependency on the mixin

The reset mixin can cause style inconsistencies by disrupting cascading arbitrarily, increasing the number of specified declarations more than needed. Though it might be useful for development, it is not necessary to use it, makes it difficult to grasp the style structure, and can be removed to optimize the structure.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove element='button' from AccessibleButton

Since AccessibleButton has role='button' by default, setting the element button property is redundant.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Protect mx_ShareType_option from being regressed structurally

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style --fix

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Wrap buttons with declarations for spacing

box-sizing is not required for the buttons or the wrapper.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style --fix

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* fix eslint errors

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Fix LocationShareMenu-test.tsx

AccessibleButton is div by default

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Reflect the review

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Revert "Remove element='button' from AccessibleButton"

This reverts commit af78d2713f6b4fca9405498e0090db1e6218ff1b.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Revert "Fix LocationShareMenu-test.tsx"

This reverts commit 7d783a733ec84af6453b2359b2d00443fcece2ef.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-02 14:18:26 +02:00
..
_EnableLiveShare.scss LLS: expose way to enable live sharing labs flag from location dialog (#8416) 2022-04-28 13:37:20 +02:00
_LiveDurationDropdown.scss Live location share - set time limit (#8082) 2022-03-21 12:42:58 +01:00
_LocationShareMenu.scss
_MapError.scss fallback to event text in location body when map unavailable (#7982) 2022-03-11 09:52:57 +01:00
_MapFallback.scss Live location sharing - update live location tiles (PSF-1027) (#8649) 2022-05-20 09:49:01 +00:00
_Marker.scss Live location sharing - extract location markers into generic Marker (#8225) 2022-04-06 12:40:39 +01:00
_ShareDialogButtons.scss Location sharing > back button (#7958) 2022-03-03 11:30:46 +01:00
_ShareType.scss Improve _ShareType.scss (#8737) 2022-06-02 14:18:26 +02:00
_ZoomButtons.scss Live location sharing - extract zoom buttons into component (#8235) 2022-04-11 10:29:07 +02:00