mirror of https://github.com/tootsuite/mastodon
Improve performance of account_media_status_ids (#6729)
parent
36579bac88
commit
37b043d447
|
@ -51,7 +51,13 @@ class Api::V1::Accounts::StatusesController < Api::BaseController
|
||||||
end
|
end
|
||||||
|
|
||||||
def account_media_status_ids
|
def account_media_status_ids
|
||||||
@account.media_attachments.attached.reorder(nil).select(:status_id).distinct
|
# `SELECT DISTINCT id, updated_at` is too slow, so pluck ids at first, and then select id, updated_at with ids.
|
||||||
|
# Also, Avoid getting slow by not narrowing down by `statuses.account_id`.
|
||||||
|
# When narrowing down by `statuses.account_id`, `index_statuses_20180106` will be used
|
||||||
|
# and the table will be joined by `Merge Semi Join`, so the query will be slow.
|
||||||
|
Status.joins(:media_attachments).merge(@account.media_attachments).permitted_for(@account, current_account)
|
||||||
|
.paginate_by_max_id(limit_param(DEFAULT_STATUSES_LIMIT), params[:max_id], params[:since_id])
|
||||||
|
.reorder(id: :desc).distinct(:id).pluck(:id)
|
||||||
end
|
end
|
||||||
|
|
||||||
def pinned_scope
|
def pinned_scope
|
||||||
|
|
Loading…
Reference in New Issue