From 6c68c3c0ce610a7d816249e2f8139863c3129047 Mon Sep 17 00:00:00 2001 From: Matt Jankowski Date: Tue, 19 Mar 2024 05:03:15 -0400 Subject: [PATCH] Introduce `inline_svg` gem, minimal usage, prep for material design icons (#29612) --- Gemfile | 1 + Gemfile.lock | 4 ++++ app/helpers/application_helper.rb | 2 +- app/javascript/images/check.svg | 4 ++++ config/initializers/propshaft.rb | 3 +++ 5 files changed, 13 insertions(+), 1 deletion(-) create mode 100644 app/javascript/images/check.svg create mode 100644 config/initializers/propshaft.rb diff --git a/Gemfile b/Gemfile index d3bfeb44870..3a1ff81d43d 100644 --- a/Gemfile +++ b/Gemfile @@ -59,6 +59,7 @@ gem 'http', '~> 5.1' gem 'http_accept_language', '~> 2.1' gem 'httplog', '~> 1.6.2' gem 'idn-ruby', require: 'idn' +gem 'inline_svg' gem 'kaminari', '~> 1.2' gem 'link_header', '~> 0.0' gem 'mime-types', '~> 3.5.0', require: 'mime/types/columnar' diff --git a/Gemfile.lock b/Gemfile.lock index 9de472091cc..9c5bb940bc4 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -350,6 +350,9 @@ GEM rainbow (>= 2.2.2, < 4.0) terminal-table (>= 1.5.1) idn-ruby (0.1.5) + inline_svg (1.9.0) + activesupport (>= 3.0) + nokogiri (>= 1.6) io-console (0.7.2) irb (1.12.0) rdoc @@ -865,6 +868,7 @@ DEPENDENCIES httplog (~> 1.6.2) i18n-tasks (~> 1.0) idn-ruby + inline_svg irb (~> 1.8) json-ld json-ld-preloaded (~> 3.2) diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index 7dc7d60808f..668afe7fde1 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -114,7 +114,7 @@ module ApplicationHelper end def check_icon - content_tag(:svg, tag.path('fill-rule': 'evenodd', 'clip-rule': 'evenodd', d: 'M16.704 4.153a.75.75 0 01.143 1.052l-8 10.5a.75.75 0 01-1.127.075l-4.5-4.5a.75.75 0 011.06-1.06l3.894 3.893 7.48-9.817a.75.75 0 011.05-.143z'), xmlns: 'http://www.w3.org/2000/svg', viewBox: '0 0 20 20', fill: 'currentColor') + inline_svg_tag 'check.svg' end def visibility_icon(status) diff --git a/app/javascript/images/check.svg b/app/javascript/images/check.svg new file mode 100644 index 00000000000..8a0ebe878d1 --- /dev/null +++ b/app/javascript/images/check.svg @@ -0,0 +1,4 @@ + + + \ No newline at end of file diff --git a/config/initializers/propshaft.rb b/config/initializers/propshaft.rb new file mode 100644 index 00000000000..6cf368d5b7d --- /dev/null +++ b/config/initializers/propshaft.rb @@ -0,0 +1,3 @@ +# frozen_string_literal: true + +Rails.application.config.assets.paths << Rails.root.join('app', 'javascript', 'images')