From a07fbe68c98eadf29b07edce5215c289ea378fbd Mon Sep 17 00:00:00 2001 From: Matt Jankowski Date: Tue, 23 Apr 2024 14:32:49 -0400 Subject: [PATCH] Disable `Style/GuardClause` cop --- .rubocop.yml | 5 +++++ .rubocop_todo.yml | 29 ----------------------------- 2 files changed, 5 insertions(+), 29 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index 542e90b5e3..da0f9388c0 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -182,6 +182,11 @@ Style/FormatStringToken: AllowedMethods: - redirect_with_vary +# Reason: Prevailing style choice +# https://docs.rubocop.org/rubocop/cops_style.html#styleguardclause +Style/GuardClause: + Enabled: false + # Reason: Prevailing style choice # https://docs.rubocop.org/rubocop/cops_style.html#stylehashaslastarrayitem Style/HashAsLastArrayItem: diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 25b573017b..4457c49c94 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -91,35 +91,6 @@ Style/GlobalStdStream: - 'config/environments/development.rb' - 'config/environments/production.rb' -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: MinBodyLength, AllowConsecutiveConditionals. -Style/GuardClause: - Exclude: - - 'app/lib/activitypub/activity/block.rb' - - 'app/lib/request.rb' - - 'app/lib/request_pool.rb' - - 'app/lib/webfinger.rb' - - 'app/lib/webfinger_resource.rb' - - 'app/models/concerns/account/counters.rb' - - 'app/models/concerns/user/ldap_authenticable.rb' - - 'app/models/tag.rb' - - 'app/models/user.rb' - - 'app/services/fan_out_on_write_service.rb' - - 'app/services/post_status_service.rb' - - 'app/services/process_hashtags_service.rb' - - 'app/workers/move_worker.rb' - - 'app/workers/redownload_avatar_worker.rb' - - 'app/workers/redownload_header_worker.rb' - - 'app/workers/redownload_media_worker.rb' - - 'app/workers/remote_account_refresh_worker.rb' - - 'config/initializers/devise.rb' - - 'lib/devise/strategies/two_factor_ldap_authenticatable.rb' - - 'lib/devise/strategies/two_factor_pam_authenticatable.rb' - - 'lib/mastodon/cli/accounts.rb' - - 'lib/mastodon/cli/maintenance.rb' - - 'lib/mastodon/cli/media.rb' - - 'lib/tasks/repo.rake' - # This cop supports unsafe autocorrection (--autocorrect-all). Style/HashTransformValues: Exclude: