Add spec for `CLI::Maintenance#fix_duplicates` (#28326)

pull/28432/head
Matt Jankowski 2023-12-19 08:10:33 -05:00 committed by GitHub
parent 5489d4c84c
commit c7c727994a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 74 additions and 1 deletions

View File

@ -546,7 +546,7 @@ module Mastodon::CLI
if migrator_version < 2021_04_21_121431
ActiveRecord::Base.connection.add_index :tags, 'lower((name)::text)', name: 'index_tags_on_name_lower', unique: true
else
ActiveRecord::Base.connection.execute 'CREATE UNIQUE INDEX CONCURRENTLY index_tags_on_name_lower_btree ON tags (lower(name) text_pattern_ops)'
ActiveRecord::Base.connection.execute 'CREATE UNIQUE INDEX index_tags_on_name_lower_btree ON tags (lower(name) text_pattern_ops)'
end
end

View File

@ -52,5 +52,78 @@ describe Mastodon::CLI::Maintenance do
.and raise_error(SystemExit)
end
end
context 'when requirements are met' do
before do
allow(ActiveRecord::Migrator).to receive(:current_version).and_return(2023_08_22_081029) # The latest migration before the cutoff
agree_to_backup_warning
end
context 'with duplicate accounts' do
before do
prepare_duplicate_data
end
let(:duplicate_account_username) { 'username' }
let(:duplicate_account_domain) { 'host.example' }
it 'runs the deduplication process' do
expect { subject }
.to output_results(
'Deduplicating accounts',
'Restoring index_accounts_on_username_and_domain_lower',
'Reindexing textual indexes on accounts…',
'Finished!'
)
.and change(duplicate_accounts, :count).from(2).to(1)
end
def duplicate_accounts
Account.where(username: duplicate_account_username, domain: duplicate_account_domain)
end
def prepare_duplicate_data
ActiveRecord::Base.connection.remove_index :accounts, name: :index_accounts_on_username_and_domain_lower
Fabricate(:account, username: duplicate_account_username, domain: duplicate_account_domain)
Fabricate.build(:account, username: duplicate_account_username, domain: duplicate_account_domain).save(validate: false)
end
end
context 'with duplicate users' do
before do
prepare_duplicate_data
end
let(:duplicate_email) { 'duplicate@example.host' }
it 'runs the deduplication process' do
expect { subject }
.to output_results(
'Deduplicating user records',
'Restoring users indexes',
'Finished!'
)
.and change(duplicate_users, :count).from(2).to(1)
end
def duplicate_users
User.where(email: duplicate_email)
end
def prepare_duplicate_data
ActiveRecord::Base.connection.remove_index :users, :email
Fabricate(:user, email: duplicate_email)
Fabricate.build(:user, email: duplicate_email).save(validate: false)
end
end
def agree_to_backup_warning
allow(cli.shell)
.to receive(:yes?)
.with('Continue? (Yes/No)')
.and_return(true)
.once
end
end
end
end