From dbe0ee8a81516eccbbc6d47278e727b96cba841e Mon Sep 17 00:00:00 2001 From: Matt Jankowski Date: Mon, 26 Aug 2024 11:00:05 -0400 Subject: [PATCH] Convert `emojis` controller spec to request spec (#31597) Co-authored-by: Claire --- spec/controllers/emojis_controller_spec.rb | 18 ------------------ spec/requests/emojis_spec.rb | 21 +++++++++++++++++++++ 2 files changed, 21 insertions(+), 18 deletions(-) delete mode 100644 spec/controllers/emojis_controller_spec.rb create mode 100644 spec/requests/emojis_spec.rb diff --git a/spec/controllers/emojis_controller_spec.rb b/spec/controllers/emojis_controller_spec.rb deleted file mode 100644 index dd139de931..0000000000 --- a/spec/controllers/emojis_controller_spec.rb +++ /dev/null @@ -1,18 +0,0 @@ -# frozen_string_literal: true - -require 'rails_helper' - -describe EmojisController do - render_views - - let(:emoji) { Fabricate(:custom_emoji, shortcode: 'coolcat') } - - describe 'GET #show' do - let(:response) { get :show, params: { id: emoji.id, format: :json } } - - it 'returns the right response' do - expect(response).to have_http_status 200 - expect(body_as_json[:name]).to eq ':coolcat:' - end - end -end diff --git a/spec/requests/emojis_spec.rb b/spec/requests/emojis_spec.rb new file mode 100644 index 0000000000..458d500762 --- /dev/null +++ b/spec/requests/emojis_spec.rb @@ -0,0 +1,21 @@ +# frozen_string_literal: true + +require 'rails_helper' + +describe 'Emojis' do + describe 'GET /emojis/:id' do + let(:emoji) { Fabricate(:custom_emoji, shortcode: 'coolcat') } + + it 'returns http success with correct json' do + get "/emojis/#{emoji.id}" + + expect(response) + .to have_http_status(200) + expect(body_as_json) + .to include( + name: ':coolcat:', + type: 'Emoji' + ) + end + end +end