OpenCloud
/
riot-web
mirror of https://github.com/vector-im/riot-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Improve typing 

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
pull/21833/head
Šimon Brandner 2021-09-14 17:38:34 +02:00
parent ffb3e98e3e
commit 047767bab0
No known key found for this signature in database
GPG Key ID: 55C211A1226CB17D
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/components/views/dialogs/FeedbackDialog.tsx
View File

@ -34,7 +34,7 @@ const newIssueUrl = "https://github.com/vector-im/element-web/issues/new/choose"
interface IProps extends IDialogProps {} interface IProps extends IDialogProps {}
const FeedbackDialog: React.FC<IProps> = (props: IProps) => { const FeedbackDialog: React.FC<IProps> = (props: IProps) => {
const [rating, setRating] = useState<string>(); const [rating, setRating] = useState<Rating>();
const [comment, setComment] = useState<string>(""); const [comment, setComment] = useState<string>("");
const onDebugLogsLinkClick = (): void => { const onDebugLogsLinkClick = (): void => {
@ -45,7 +45,7 @@ const FeedbackDialog: React.FC<IProps> = (props: IProps) => {
const hasFeedback = CountlyAnalytics.instance.canEnable(); const hasFeedback = CountlyAnalytics.instance.canEnable();
const onFinished = (sendFeedback: boolean): void => { const onFinished = (sendFeedback: boolean): void => {
if (hasFeedback && sendFeedback) { if (hasFeedback && sendFeedback) {
CountlyAnalytics.instance.reportFeedback((parseInt(rating) as Rating), comment); CountlyAnalytics.instance.reportFeedback(rating, comment);
Modal.createTrackedDialog('Feedback sent', '', InfoDialog, { Modal.createTrackedDialog('Feedback sent', '', InfoDialog, {
title: _t('Feedback sent'), title: _t('Feedback sent'),
description: _t('Thank you!'), description: _t('Thank you!'),
@ -68,8 +68,8 @@ const FeedbackDialog: React.FC<IProps> = (props: IProps) => {
<StyledRadioGroup <StyledRadioGroup
name="feedbackRating" name="feedbackRating"
value={rating} value={String(rating)}
onChange={setRating} onChange={(r) => setRating(parseInt(r, 10) as Rating)}
definitions={[ definitions={[
{ value: "1", label: "😠" }, { value: "1", label: "😠" },
{ value: "2", label: "😞" }, { value: "2", label: "😞" },
@ -141,7 +141,7 @@ const FeedbackDialog: React.FC<IProps> = (props: IProps) => {
{ countlyFeedbackSection } { countlyFeedbackSection }
</React.Fragment>} </React.Fragment>}
button={hasFeedback ? _t("Send feedback") : _t("Go back")} button={hasFeedback ? _t("Send feedback") : _t("Go back")}
buttonDisabled={hasFeedback && rating === ""} buttonDisabled={hasFeedback && !rating}
onFinished={onFinished} onFinished={onFinished}
/>); />);
}; };