From 04bd5f648ffc3509931922b7f7c22dfaa5670c8a Mon Sep 17 00:00:00 2001
From: Jason Robinson <mail@jasonrobinson.me>
Date: Fri, 11 Dec 2020 16:25:22 +0200
Subject: [PATCH] Add confirmation dialog before transferring account data

---
 .../HostingSignupAccountDataConfirmDialog.tsx | 45 +++++++++++++++++++
 .../views/dialogs/HostingSignupDialog.tsx     | 20 ++++++---
 2 files changed, 59 insertions(+), 6 deletions(-)
 create mode 100644 src/components/views/dialogs/HostingSignupAccountDataConfirmDialog.tsx

diff --git a/src/components/views/dialogs/HostingSignupAccountDataConfirmDialog.tsx b/src/components/views/dialogs/HostingSignupAccountDataConfirmDialog.tsx
new file mode 100644
index 0000000000..46913a2015
--- /dev/null
+++ b/src/components/views/dialogs/HostingSignupAccountDataConfirmDialog.tsx
@@ -0,0 +1,45 @@
+/*
+Copyright 2020 The Matrix.org Foundation C.I.C.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+import React from 'react';
+import QuestionDialog from './QuestionDialog';
+import { _t } from "../../../languageHandler";
+import { IDialogProps } from "./IDialogProps";
+
+interface IProps extends IDialogProps {
+    onFinished(): void;
+}
+
+interface IState {}
+
+/*
+ * A dialog for confirming closing the Hosting signup setup dialog.
+ */
+export default class HostingSignupAccountDataConfirmDialog extends React.PureComponent<IProps, IState> {
+    public render() {
+        return (
+            <QuestionDialog
+                onFinished={this.props.onFinished}
+                title={_t("Confirm Account Data Transfer")}
+                description={
+                    "Please accept transfer of data to the Element Pro setup wizard to continue. The setup wizard" +
+                    "will be able to access your account for the duration of the setup process."
+                }
+                button={_t("Accept")}
+            />
+        );
+    }
+}
diff --git a/src/components/views/dialogs/HostingSignupDialog.tsx b/src/components/views/dialogs/HostingSignupDialog.tsx
index 2f6cb36299..5b9f6e8de6 100644
--- a/src/components/views/dialogs/HostingSignupDialog.tsx
+++ b/src/components/views/dialogs/HostingSignupDialog.tsx
@@ -15,7 +15,9 @@ limitations under the License.
 */
 
 import * as React from "react";
-import * as sdk from '../../../index';
+import BaseDialog from '../../views/dialogs/BaseDialog';
+import ConfirmCloseHostingSignupDialog from '../../views/dialogs/ConfirmCloseHostingSignupDialog';
+import HostingSignupAccountDataConfirmDialog from '../../views/dialogs/HostingSignupAccountDataConfirmDialog';
 import Modal from "../../../Modal";
 import SdkConfig from "../../../SdkConfig";
 import { _t } from "../../../languageHandler";
@@ -53,8 +55,16 @@ export default class HostingSignupDialog extends React.PureComponent<IProps, ISt
         }
         switch (message.data.action) {
             case 'element_pro_account_details_request':
-                // noinspection JSIgnoredPromiseFromCall
-                this.sendAccountDetails();
+                Modal.createDialog(
+                    HostingSignupAccountDataConfirmDialog,
+                    {
+                        onFinished: result => {
+                            if (result) {
+                                return this.sendAccountDetails();
+                            }
+                        },
+                    },
+                );
                 break;
             case 'setup_complete':
                 // Set as completed but let the user close the modal themselves
@@ -74,9 +84,8 @@ export default class HostingSignupDialog extends React.PureComponent<IProps, ISt
             // We're done, close
             this.props.requestClose();
         } else {
-            const ConfirmDialog = sdk.getComponent('views.dialogs.ConfirmCloseHostingSignupDialog');
             Modal.createDialog(
-                ConfirmDialog,
+                ConfirmCloseHostingSignupDialog,
                 {
                     onFinished: result => {
                         if (result) {
@@ -124,7 +133,6 @@ export default class HostingSignupDialog extends React.PureComponent<IProps, ISt
     }
 
     public render(): React.ReactNode {
-        const BaseDialog = sdk.getComponent('views.dialogs.BaseDialog');
         return (
             <BaseDialog
                 className="mx_HostingSignupBaseDialog"