From 101679f64708855b55f947a7d739685a5e996d82 Mon Sep 17 00:00:00 2001
From: Travis Ralston <travpc@gmail.com>
Date: Thu, 25 Mar 2021 17:30:44 -0600
Subject: [PATCH] Adjust some settings
---
.../views/voice_messages/LiveRecordingWaveform.tsx | 4 ++--
src/voice/VoiceRecorder.ts | 7 +++----
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/src/components/views/voice_messages/LiveRecordingWaveform.tsx b/src/components/views/voice_messages/LiveRecordingWaveform.tsx
index 8a2a5ae089..d0048ac9cb 100644
--- a/src/components/views/voice_messages/LiveRecordingWaveform.tsx
+++ b/src/components/views/voice_messages/LiveRecordingWaveform.tsx
@@ -49,12 +49,12 @@ export default class LiveRecordingWaveform extends React.PureComponent<IProps, I
const bars = arrayFastResample(Array.from(update.waveform), DOWNSAMPLE_TARGET);
this.setState({
// The incoming data is between zero and one, but typically even screaming into a
- // microphone won't send you over 0.6, so we "cap" the graph at about 0.35 for a
+ // microphone won't send you over 0.6, so we "cap" the graph at about 0.50 for a
// point where the average user can still see feedback and be perceived as peaking
// when talking "loudly".
//
// We multiply by 100 because the Waveform component wants values in 0-100 (percentages)
- heights: bars.map(b => percentageOf(b, 0, 0.35) * 100),
+ heights: bars.map(b => percentageOf(b, 0, 0.50) * 100),
});
};
diff --git a/src/voice/VoiceRecorder.ts b/src/voice/VoiceRecorder.ts
index dec8017b8b..6a3d392ce4 100644
--- a/src/voice/VoiceRecorder.ts
+++ b/src/voice/VoiceRecorder.ts
@@ -73,10 +73,9 @@ export class VoiceRecorder {
// The size of the audio buffer largely decides how quickly we push timing/waveform data
// out of this class. Smaller buffers mean we update more frequently as we can't hold as
// many bytes. Larger buffers mean slower updates. For scale, 1024 gives us about 30Hz of
- // updates and 2048 gives us about 20Hz. We use 2048 because it updates frequently enough
- // to feel realtime (~20fps, which is what humans perceive as "realtime"). Must be a power
- // of 2.
- this.recorderProcessor = this.recorderContext.createScriptProcessor(2048, CHANNELS, CHANNELS);
+ // updates and 2048 gives us about 20Hz. We use 1024 to get as close to perceived realtime
+ // as possible. Must be a power of 2.
+ this.recorderProcessor = this.recorderContext.createScriptProcessor(1024, CHANNELS, CHANNELS);
// Connect our inputs and outputs
this.recorderSource.connect(this.recorderFFT);