OpenCloud
/
riot-web
mirror of https://github.com/vector-im/riot-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Prevent minification of `.html` files generated by new verison html-webpack-plugin 

This described in https://github.com/vector-im/element-web/issues/17330#issuecomment-842530812, this should prevent the newly introduced version of `html-webpack-plugin` from minifying `.html` files, like e.g. `index.html`, `jitsi.html`, et cetera …

Quoting @jryans via: https://github.com/vector-im/element-web/issues/17330#issuecomment-842415694

> The content of the `index.html` file is not a supported API surface, so it might change at any time.
> 
> This document minification was not done on purpose, but instead it happened as a side effect of upgrading. We would happily accept a PR to fix this, but it is also not a priority for the core team.

Could please someone test and, hopefully, accept this change back to not minifying the `.html` files?
pull/17349/head
fooness 2021-05-18 12:35:51 +02:00 committed by GitHub
parent 7895fc1c78
commit 10194fe445
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
webpack.config.js
View File

@ -386,7 +386,7 @@ module.exports = (env, argv) => {
// of the themes and which chunks we actually care about. // of the themes and which chunks we actually care about.
inject: false, inject: false,
excludeChunks: ['mobileguide', 'usercontent', 'jitsi'], excludeChunks: ['mobileguide', 'usercontent', 'jitsi'],
minify: argv.mode === 'production', minify: false,
templateParameters: { templateParameters: {
og_image_url: ogImageUrl, og_image_url: ogImageUrl,
}, },
@ -396,7 +396,7 @@ module.exports = (env, argv) => {
new HtmlWebpackPlugin({ new HtmlWebpackPlugin({
template: './src/vector/jitsi/index.html', template: './src/vector/jitsi/index.html',
filename: 'jitsi.html', filename: 'jitsi.html',
minify: argv.mode === 'production', minify: false,
chunks: ['jitsi'], chunks: ['jitsi'],
}), }),
@ -404,7 +404,7 @@ module.exports = (env, argv) => {
new HtmlWebpackPlugin({ new HtmlWebpackPlugin({
template: './src/vector/mobile_guide/index.html', template: './src/vector/mobile_guide/index.html',
filename: 'mobile_guide/index.html', filename: 'mobile_guide/index.html',
minify: argv.mode === 'production', minify: false,
chunks: ['mobileguide'], chunks: ['mobileguide'],
}), }),
@ -412,13 +412,13 @@ module.exports = (env, argv) => {
new HtmlWebpackPlugin({ new HtmlWebpackPlugin({
template: './src/vector/static/unable-to-load.html', template: './src/vector/static/unable-to-load.html',
filename: 'static/unable-to-load.html', filename: 'static/unable-to-load.html',
minify: argv.mode === 'production', minify: false,
chunks: [], chunks: [],
}), }),
new HtmlWebpackPlugin({ new HtmlWebpackPlugin({
template: './src/vector/static/incompatible-browser.html', template: './src/vector/static/incompatible-browser.html',
filename: 'static/incompatible-browser.html', filename: 'static/incompatible-browser.html',
minify: argv.mode === 'production', minify: false,
chunks: [], chunks: [],
}), }),
@ -426,7 +426,7 @@ module.exports = (env, argv) => {
new HtmlWebpackPlugin({ new HtmlWebpackPlugin({
template: './node_modules/matrix-react-sdk/src/usercontent/index.html', template: './node_modules/matrix-react-sdk/src/usercontent/index.html',
filename: 'usercontent/index.html', filename: 'usercontent/index.html',
minify: argv.mode === 'production', minify: false,
chunks: ['usercontent'], chunks: ['usercontent'],
}), }),