OpenCloud
/
riot-web
mirror of https://github.com/vector-im/riot-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Merge pull request #27881 from element-hq/t3chguy/make-sonar-happier 

Make sonarcloud happier
pull/27891/head
Michael Telatynski 2024-07-31 20:40:08 +00:00 committed by GitHub
parent 446a4c87b6 d5f4b1bc86
commit 1424314f12
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/favicon.ts
View File

@ -101,7 +101,7 @@ export default class Favicon {
h: number;
} {
const opt = {
n: typeof n === "number" ? Math.abs(n as number | 0) : n,
n: typeof n === "number" ? Math.abs(n | 0) : n,
len: ("" + n).length,
// badge positioning constants as percentages
x: 0.4,
@ -178,7 +178,7 @@ export default class Favicon {
this.context.fillStyle = params.textColor;
if (typeof opt.n === "number" && opt.n > 999) {
const count = (opt.n > 9999 ? 9 : Math.floor((opt.n as number) / 1000)) + "k+";
const count = (opt.n > 9999 ? 9 : Math.floor(opt.n / 1000)) + "k+";
this.context.fillText(count, Math.floor(opt.x + opt.w / 2), Math.floor(opt.y + opt.h - opt.h * 0.2));
} else {
this.context.fillText("" + opt.n, Math.floor(opt.x + opt.w / 2), Math.floor(opt.y + opt.h - opt.h * 0.15));

2
src/vector/getconfig.ts
View File

@ -23,7 +23,7 @@ export async function getVectorConfig(relativeLocation = ""): Promise<IConfigOpt
// Handle trailing dot FQDNs
let domain = window.location.hostname.trimEnd();
if (domain[domain.length - 1] === ".") {
if (domain.endsWith(".")) {
domain = domain.slice(0, -1);
}

2
src/vector/localstorage-fix.ts
View File

@ -5,7 +5,7 @@
if (window.localStorage) {
Object.keys(window.localStorage).forEach((key) => {
if (key.indexOf("loglevel:") === 0) {
if (key.startsWith("loglevel:")) {
window.localStorage.removeItem(key);
}
});

4
src/vector/mobile_guide/index.ts
View File

@ -70,7 +70,7 @@ async function initPage(): Promise<void> {
try {
const result = await fetch(`https://${serverName}/.well-known/matrix/client`);
const wkConfig = await result.json();
if (wkConfig && wkConfig["m.homeserver"]) {
if (wkConfig?.["m.homeserver"]) {
hsUrl = wkConfig["m.homeserver"]["base_url"];
if (wkConfig["m.identity_server"]) {
@ -78,7 +78,7 @@ async function initPage(): Promise<void> {
}
}
} catch (e) {
if (wkConfig && wkConfig["m.homeserver"]) {
if (wkConfig?.["m.homeserver"]) {
hsUrl = wkConfig["m.homeserver"]["base_url"] || undefined;
if (wkConfig["m.identity_server"]) {