OpenCloud
/
riot-web
mirror of https://github.com/vector-im/riot-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Add rel="noopener" to context menu links.

pull/2560/head
Will Hunt 2016-11-08 17:08:50 +00:00
parent cf33ed58c1
commit 15c730a22a
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/components/views/context_menus/MessageContextMenu.js
View File

@ -74,7 +74,7 @@ module.exports = React.createClass({
if (this.props.onFinished) this.props.onFinished(); if (this.props.onFinished) this.props.onFinished();
}, },
onLinkClick: function() { closeMenu: function() {
if (this.props.onFinished) this.props.onFinished(); if (this.props.onFinished) this.props.onFinished();
}, },
@ -147,7 +147,7 @@ module.exports = React.createClass({
permalinkButton = ( permalinkButton = (
<div className="mx_MessageContextMenu_field"> <div className="mx_MessageContextMenu_field">
<a href={ "https://matrix.to/#/" + this.props.mxEvent.getRoomId() +"/"+ this.props.mxEvent.getId() } <a href={ "https://matrix.to/#/" + this.props.mxEvent.getRoomId() +"/"+ this.props.mxEvent.getId() }
target="_blank" onClick={ this.onLinkClick }>Permalink</a> target="_blank" rel="noopener" onClick={ this.closeMenu }>Permalink</a>
</div> </div>
); );
@ -161,8 +161,8 @@ module.exports = React.createClass({
if( typeof(this.props.mxEvent.event.content.external_url) === "string") { if( typeof(this.props.mxEvent.event.content.external_url) === "string") {
externalURLButton = ( externalURLButton = (
<div className="mx_MessageContextMenu_field"> <div className="mx_MessageContextMenu_field">
<a target="_blank" href={ this.props.mxEvent.event.content.external_url } <a href={ this.props.mxEvent.event.content.external_url }
onClick={ this.onLinkClick }>Source URL</a> rel="noopener" target="_blank" onClick={ this.closeMenu }>Source URL</a>
</div> </div>
); );
} }