From 59da9043537418956bdbe6879bdf1137722f52a9 Mon Sep 17 00:00:00 2001
From: Richard van der Hoff <github@rvanderhoff.org.uk>
Date: Wed, 14 Jun 2017 16:59:00 +0100
Subject: [PATCH] Check that we don't register a guest account on /#/login
 (#4306)

If you go straight to a /#/login link, we shoudn't go registering guest
accounts or reanimating the saved creds.
---
 test/app-tests/loading.js | 53 ++++++++++++++++++++++++++++++++-------
 1 file changed, 44 insertions(+), 9 deletions(-)

diff --git a/test/app-tests/loading.js b/test/app-tests/loading.js
index 3f98b4f11b..0248986b2c 100644
--- a/test/app-tests/loading.js
+++ b/test/app-tests/loading.js
@@ -237,6 +237,36 @@ describe('loading:', function () {
                 expect(localStorage.getItem('mx_is_url')).toEqual(DEFAULT_IS_URL);
             }).done(done, done);
         });
+
+        it('should not register as a guest when using a #/login link', function() {
+            loadApp({
+                uriFragment: "#/login",
+            });
+
+            return q.delay(100).then(() => {
+                // we expect a single <Login> component
+                ReactTestUtils.findRenderedComponentWithType(
+                    matrixChat, sdk.getComponent('structures.login.Login'));
+
+                // the only outstanding request should be a GET /login
+                // (in particular there should be no /register request for
+                // guest registration).
+                for (const req of httpBackend.requests) {
+                    if (req.method === 'GET' && req.path.endsWith('/_matrix/client/r0/login')) {
+                        continue;
+                    }
+
+                    throw new Error(`Unexpected HTTP request to ${req}`);
+                }
+                return completeLogin(matrixChat);
+            }).then(() => {
+
+                // once the sync completes, we should have a room view
+                ReactTestUtils.findRenderedComponentWithType(
+                    matrixChat, sdk.getComponent('structures.HomePage'));
+                expect(windowLocation.hash).toEqual("#/home");
+            });
+        });
     });
 
     describe("MatrixClient rehydrated from stored credentials:", function() {
@@ -308,28 +338,33 @@ describe('loading:', function () {
 
         describe('/#/login link:', function() {
             beforeEach(function() {
-                httpBackend.when('GET', '/pushrules').respond(200, {});
-                httpBackend.when('POST', '/filter').respond(200, { filter_id: 'fid' });
-
                 loadApp({
                     uriFragment: "#/login",
                 });
-
-                return expectAndAwaitSync().then(() => {
-                    return q.delay(1);
-                });
             });
 
             it('shows a login view', function() {
                 // we expect a single <Login> component
-                const login = ReactTestUtils.findRenderedComponentWithType(
+                ReactTestUtils.findRenderedComponentWithType(
                     matrixChat, sdk.getComponent('structures.login.Login')
                 );
+
+                // the only outstanding request should be a GET /login
+                // (in particular there should be no /register request for
+                // guest registration, nor /sync, etc).
+                for (const req of httpBackend.requests) {
+                    if (req.method === 'GET' && req.path.endsWith('/_matrix/client/r0/login')) {
+                        continue;
+                    }
+
+                    throw new Error(`Unexpected HTTP request to ${req}`);
+                }
             });
 
             it('shows the homepage after login', function() {
                 return completeLogin(matrixChat).then(() => {
-                    // we should see a home page if we previously had no room
+                    // we should see a home page, even though we previously had
+                    // a stored mx_last_room_id
                     ReactTestUtils.findRenderedComponentWithType(
                         matrixChat, sdk.getComponent('structures.HomePage'));
                     expect(windowLocation.hash).toEqual("#/home");