OpenCloud
/
riot-web
mirror of https://github.com/vector-im/riot-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Add multi-repo PR linking 

Co-Authored-By: Travis Ralston <travpc@gmail.com>
pull/12730/head
J. Ryan Stinnett 2020-03-18 10:18:41 +00:00 committed by GitHub
parent 0b772ca50a
commit 1aecc3d7e5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
docs/review.md
View File

@ -37,6 +37,9 @@ When reviewing code, here are some things we look for and also things we avoid:
* Take the time to thank and point out good code changes * Take the time to thank and point out good code changes
* Using softer language like "please" and "what do you think?" goes a long way * Using softer language like "please" and "what do you think?" goes a long way
towards making others feel like colleagues working towards a common goal towards making others feel like colleagues working towards a common goal
* Authors should link to other layers of their PR in their PR before requesting
review. Reviewers might be coming from different places and could miss other
required PRs.
### Workflow ### Workflow