OpenCloud
/
riot-web
mirror of https://github.com/vector-im/riot-web
1
0
Fork 0
Code Issues Releases Wiki Activity

TODO comments on the registration flow 

Add some notes to Signup and the Registration component that it would be nice
to factor out some common code someday.
pull/21833/head
Richard van der Hoff 2016-10-12 14:27:21 +01:00
parent 1a81397d31
commit 1e683427da
2 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/Signup.js
View File

@ -54,6 +54,9 @@ class Signup {
* This exists for the lifetime of a user's attempt to register an account, * This exists for the lifetime of a user's attempt to register an account,
* so if their registration attempt fails for whatever reason and they * so if their registration attempt fails for whatever reason and they
* try again, call register() on the same instance again. * try again, call register() on the same instance again.
*
* TODO: parts of this overlap heavily with InteractiveAuth in the js-sdk. It
* would be nice to make use of that rather than rolling our own version of it.
*/ */
class Register extends Signup { class Register extends Signup {
constructor(hsUrl, isUrl, opts) { constructor(hsUrl, isUrl, opts) {

4
src/components/structures/login/Registration.js
View File

@ -28,6 +28,10 @@ var CaptchaForm = require("../../views/login/CaptchaForm");
var MIN_PASSWORD_LENGTH = 6; var MIN_PASSWORD_LENGTH = 6;
/**
* TODO: It would be nice to make use of the InteractiveAuthEntryComponents
* here, rather than inventing our own.
*/
module.exports = React.createClass({ module.exports = React.createClass({
displayName: 'Registration', displayName: 'Registration',