From 2120963c7a7eee0d9e4db115abb6b6e9eb63431c Mon Sep 17 00:00:00 2001 From: David Baker Date: Fri, 23 Sep 2016 14:02:14 +0100 Subject: [PATCH] More linkifier fixes * Accept underscores in usernames * Accept usernames & room aliases on localhost * Accept #localhost:foo.com and @localhost:foo.com --- src/linkify-matrix.js | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/linkify-matrix.js b/src/linkify-matrix.js index 1e93d8c387..8dceb3a527 100644 --- a/src/linkify-matrix.js +++ b/src/linkify-matrix.js @@ -45,6 +45,10 @@ function matrixLinkify(linkify) { TT.TLD, TT.UNDERSCORE, TT.POUND, + + // because 'localhost' is tokenised to the localhost token, + // usernames @localhost:foo.com are otherwise not matched! + TT.LOCALHOST, ]; S_START.on(TT.POUND, S_HASH); @@ -56,6 +60,7 @@ function matrixLinkify(linkify) { S_HASH_NAME.on(TT.COLON, S_HASH_NAME_COLON); S_HASH_NAME_COLON.on(TT.DOMAIN, S_HASH_NAME_COLON_DOMAIN); + S_HASH_NAME_COLON.on(TT.LOCALHOST, S_ROOMALIAS); // accept #foo:localhost S_HASH_NAME_COLON_DOMAIN.on(TT.DOT, S_HASH_NAME_COLON_DOMAIN_DOT); S_HASH_NAME_COLON_DOMAIN_DOT.on(TT.DOMAIN, S_HASH_NAME_COLON_DOMAIN); S_HASH_NAME_COLON_DOMAIN_DOT.on(TT.TLD, S_ROOMALIAS); @@ -77,10 +82,14 @@ function matrixLinkify(linkify) { var username_tokens = [ TT.DOT, + TT.UNDERSCORE, TT.PLUS, TT.NUM, TT.DOMAIN, - TT.TLD + TT.TLD, + + // as in roomname_tokens + TT.LOCALHOST, ]; S_START.on(TT.AT, S_AT); @@ -92,6 +101,7 @@ function matrixLinkify(linkify) { S_AT_NAME.on(TT.COLON, S_AT_NAME_COLON); S_AT_NAME_COLON.on(TT.DOMAIN, S_AT_NAME_COLON_DOMAIN); + S_AT_NAME_COLON.on(TT.LOCALHOST, S_USERID); // accept @foo:localhost S_AT_NAME_COLON_DOMAIN.on(TT.DOT, S_AT_NAME_COLON_DOMAIN_DOT); S_AT_NAME_COLON_DOMAIN_DOT.on(TT.DOMAIN, S_AT_NAME_COLON_DOMAIN); S_AT_NAME_COLON_DOMAIN_DOT.on(TT.TLD, S_USERID);