From 226700ba9563be823aa4385015ce037e3464eae0 Mon Sep 17 00:00:00 2001 From: Travis Ralston Date: Thu, 24 Mar 2022 16:02:33 -0600 Subject: [PATCH] Step 8.5: Move report event dialog construction --- .../context_menus/MessageContextMenu.tsx | 9 ++++--- src/dispatcher/actions.ts | 6 +++++ .../payloads/OpenReportEventDialogPayload.ts | 26 +++++++++++++++++++ src/utils/DialogOpener.ts | 6 +++++ 4 files changed, 43 insertions(+), 4 deletions(-) create mode 100644 src/dispatcher/payloads/OpenReportEventDialogPayload.ts diff --git a/src/components/views/context_menus/MessageContextMenu.tsx b/src/components/views/context_menus/MessageContextMenu.tsx index 00b0a69778..b4f476a5cd 100644 --- a/src/components/views/context_menus/MessageContextMenu.tsx +++ b/src/components/views/context_menus/MessageContextMenu.tsx @@ -34,7 +34,6 @@ import { isContentActionable } from '../../../utils/EventUtils'; import IconizedContextMenu, { IconizedContextMenuOption, IconizedContextMenuOptionList } from './IconizedContextMenu'; import { ReadPinsEventId } from "../right_panel/types"; import { Action } from "../../../dispatcher/actions"; -import ReportEventDialog from '../dialogs/ReportEventDialog'; import ViewSource from '../../structures/ViewSource'; import { createRedactEventDialog } from '../dialogs/ConfirmRedactDialog'; import ShareDialog from '../dialogs/ShareDialog'; @@ -47,6 +46,7 @@ import EndPollDialog from '../dialogs/EndPollDialog'; import { isPollEnded } from '../messages/MPollBody'; import { ViewRoomPayload } from "../../../dispatcher/payloads/ViewRoomPayload"; import { OpenForwardDialogPayload } from "../../../dispatcher/payloads/OpenForwardDialogPayload"; +import { OpenReportEventDialogPayload } from "../../../dispatcher/payloads/OpenReportEventDialogPayload"; import { createMapSiteLink } from '../../../utils/location'; export function canCancel(status: EventStatus): boolean { @@ -154,9 +154,10 @@ export default class MessageContextMenu extends React.Component }; private onReportEventClick = (): void => { - Modal.createTrackedDialog('Report Event', '', ReportEventDialog, { - mxEvent: this.props.mxEvent, - }, 'mx_Dialog_reportEvent'); + dis.dispatch({ + action: Action.OpenReportEventDialog, + event: this.props.mxEvent, + } as OpenReportEventDialogPayload); this.closeMenu(); }; diff --git a/src/dispatcher/actions.ts b/src/dispatcher/actions.ts index 12053e204d..165438e86b 100644 --- a/src/dispatcher/actions.ts +++ b/src/dispatcher/actions.ts @@ -271,4 +271,10 @@ export enum Action { * Payload: OpenForwardDialogPayload */ OpenForwardDialog = "open_forward_dialog", + + /** + * Fired when the "report event" dialog needs to be opened. + * Payload: OpenReportEventDialogPayload. + */ + OpenReportEventDialog = "open_report_event_dialog", } diff --git a/src/dispatcher/payloads/OpenReportEventDialogPayload.ts b/src/dispatcher/payloads/OpenReportEventDialogPayload.ts new file mode 100644 index 0000000000..1af103871d --- /dev/null +++ b/src/dispatcher/payloads/OpenReportEventDialogPayload.ts @@ -0,0 +1,26 @@ +/* +Copyright 2022 The Matrix.org Foundation C.I.C. + +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +import { MatrixEvent } from "matrix-js-sdk/src/models/event"; + +import { Action } from "../actions"; +import { ActionPayload } from "../payloads"; + +export interface OpenReportEventDialogPayload extends ActionPayload { + action: Action.OpenReportEventDialog; + + event: MatrixEvent; +} diff --git a/src/utils/DialogOpener.ts b/src/utils/DialogOpener.ts index ca4ab85b13..1b21b1b871 100644 --- a/src/utils/DialogOpener.ts +++ b/src/utils/DialogOpener.ts @@ -22,6 +22,7 @@ import { RoomViewStore } from "../stores/RoomViewStore"; import ForwardDialog from "../components/views/dialogs/ForwardDialog"; import { MatrixClientPeg } from "../MatrixClientPeg"; import { Action } from "../dispatcher/actions"; +import ReportEventDialog from "../components/views/dialogs/ReportEventDialog"; /** * Auxiliary class to listen for dialog opening over the dispatcher and @@ -59,6 +60,11 @@ export class DialogOpener { permalinkCreator: payload.permalinkCreator, }); break; + case Action.OpenReportEventDialog: + Modal.createTrackedDialog('Report Event', '', ReportEventDialog, { + event: payload.event, + }, 'mx_Dialog_reportEvent'); + break; } }; }