Merge commit from fork

Handle rendering of invalid date errors
pull/28427/head
Michael Telatynski 2024-11-12 09:08:32 +00:00 committed by GitHub
commit 231073c578
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 54 additions and 16 deletions

View File

@ -96,6 +96,7 @@ export default class DateSeparator extends React.Component<IProps, IState> {
} }
private getLabel(): string { private getLabel(): string {
try {
const date = new Date(this.props.ts); const date = new Date(this.props.ts);
const disableRelativeTimestamps = !SettingsStore.getValue(UIFeature.TimelineEnableRelativeDates); const disableRelativeTimestamps = !SettingsStore.getValue(UIFeature.TimelineEnableRelativeDates);
@ -116,6 +117,9 @@ export default class DateSeparator extends React.Component<IProps, IState> {
} else { } else {
return formatFullDateNoTime(date); return formatFullDateNoTime(date);
} }
} catch {
return _t("common|message_timestamp_invalid");
}
} }
private pickDate = async (inputTimestamp: number | string | Date): Promise<void> => { private pickDate = async (inputTimestamp: number | string | Date): Promise<void> => {

View File

@ -506,6 +506,7 @@
"matrix": "Matrix", "matrix": "Matrix",
"message": "Message", "message": "Message",
"message_layout": "Message layout", "message_layout": "Message layout",
"message_timestamp_invalid": "Invalid timestamp",
"microphone": "Microphone", "microphone": "Microphone",
"model": "Model", "model": "Model",
"modern": "Modern", "modern": "Modern",

View File

@ -91,6 +91,12 @@ describe("DateSeparator", () => {
expect(getComponent({ ts, forExport: false }).container.textContent).toEqual(result); expect(getComponent({ ts, forExport: false }).container.textContent).toEqual(result);
}); });
it("renders invalid date separator correctly", () => {
const ts = new Date(-8640000000000004).getTime();
const { asFragment } = getComponent({ ts });
expect(asFragment()).toMatchSnapshot();
});
describe("when forExport is true", () => { describe("when forExport is true", () => {
it.each(testCases)("formats date in full when current time is %s", (_d, ts) => { it.each(testCases)("formats date in full when current time is %s", (_d, ts) => {
expect(getComponent({ ts, forExport: true }).container.textContent).toEqual( expect(getComponent({ ts, forExport: true }).container.textContent).toEqual(

View File

@ -1,5 +1,32 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP // Jest Snapshot v1, https://goo.gl/fbAQLP
exports[`DateSeparator renders invalid date separator correctly 1`] = `
<DocumentFragment>
<div
aria-label="Invalid timestamp"
class="mx_TimelineSeparator"
role="separator"
>
<hr
role="none"
/>
<div
class="mx_DateSeparator_dateContent"
>
<h2
aria-hidden="true"
class="mx_DateSeparator_dateHeading"
>
Invalid timestamp
</h2>
</div>
<hr
role="none"
/>
</div>
</DocumentFragment>
`;
exports[`DateSeparator renders the date separator correctly 1`] = ` exports[`DateSeparator renders the date separator correctly 1`] = `
<DocumentFragment> <DocumentFragment>
<div <div