OpenCloud
/
riot-web
mirror of https://github.com/vector-im/riot-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Don't set tags on notifications 

They are to suppress notifications that don't want to be shown in
addition to each other. This makes no sense for our notifications:
they're each for independent messages. Also settings tags on
notifications makes electron crash on windows when you close the
notif, as per https://github.com/vector-im/riot-web/issues/7512
pull/7518/head
David Baker 2018-10-18 19:07:59 +01:00
parent 47493fa7d9
commit 2854c0969b
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/vector/platform/ElectronPlatform.js
View File

@ -143,7 +143,6 @@ export default class ElectronPlatform extends VectorBasePlatform {
{ {
body: msg, body: msg,
icon: avatarUrl, icon: avatarUrl,
tag: 'vector',
silent: true, // we play our own sounds silent: true, // we play our own sounds
}, },
); );
@ -169,11 +168,6 @@ export default class ElectronPlatform extends VectorBasePlatform {
} }
clearNotification(notif: Notification) { clearNotification(notif: Notification) {
// This crashes on windows under certain circumstances: can't find any
// workaround other than not closing notifs.
// https://github.com/electron/electron/issues/15251
// https://github.com/vector-im/riot-web/issues/7512
if (window.process.platform === 'win32') return;
notif.close(); notif.close();
} }