From 2b14f2af5c3f54b61a743968c696d2ffc989ef73 Mon Sep 17 00:00:00 2001
From: "J. Ryan Stinnett" <jryans@gmail.com>
Date: Thu, 13 Dec 2018 12:10:08 +0000
Subject: [PATCH] Clean up when new key backup version fails to backup

If creating a new key backup version succeeds but backing up to it fails, delete
the version to avoid surprises. In addition, this converts the creation of a new
key backup to async / await style.

Signed-off-by: J. Ryan Stinnett <jryans@gmail.com>
---
 .../keybackup/CreateKeyBackupDialog.js        | 24 ++++++++++++-------
 1 file changed, 16 insertions(+), 8 deletions(-)

diff --git a/src/async-components/views/dialogs/keybackup/CreateKeyBackupDialog.js b/src/async-components/views/dialogs/keybackup/CreateKeyBackupDialog.js
index 6b115b890f..0db9d0699b 100644
--- a/src/async-components/views/dialogs/keybackup/CreateKeyBackupDialog.js
+++ b/src/async-components/views/dialogs/keybackup/CreateKeyBackupDialog.js
@@ -92,25 +92,33 @@ export default React.createClass({
         });
     },
 
-    _createBackup: function() {
+    _createBackup: async function() {
         this.setState({
             phase: PHASE_BACKINGUP,
             error: null,
         });
-        this._createBackupPromise = MatrixClientPeg.get().createKeyBackupVersion(
-            this._keyBackupInfo,
-        ).then((info) => {
-            return MatrixClientPeg.get().backupAllGroupSessions(info.version);
-        }).then(() => {
+        let info;
+        try {
+            info = await MatrixClientPeg.get().createKeyBackupVersion(
+                this._keyBackupInfo,
+            );
+            await MatrixClientPeg.get().backupAllGroupSessions(info.version);
             this.setState({
                 phase: PHASE_DONE,
             });
-        }).catch(e => {
+        } catch (e) {
             console.log("Error creating key backup", e);
+            // TODO: If creating a version succeeds, but backup fails, should we
+            // delete the version, disable backup, or do nothing?  If we just
+            // disable without deleting, we'll enable on next app reload since
+            // it is trusted.
+            if (info) {
+                MatrixClientPeg.get().deleteKeyBackupVersion(info.version);
+            }
             this.setState({
                 error: e,
             });
-        });
+        }
     },
 
     _onCancel: function() {