From 31f5d012b8516db71adb8f11f416b70c60a87541 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C5=A0imon=20Brandner?= <simon.bra.ag@gmail.com>
Date: Fri, 16 Jul 2021 21:16:07 +0200
Subject: [PATCH] Improve the look and feel of the picker
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
---
 .../_DesktopCapturerSourcePicker.scss         | 82 ++++++++-----------
 .../elements/DesktopCapturerSourcePicker.tsx  | 14 ++--
 2 files changed, 40 insertions(+), 56 deletions(-)

diff --git a/res/css/views/elements/_DesktopCapturerSourcePicker.scss b/res/css/views/elements/_DesktopCapturerSourcePicker.scss
index 489a9f3a79..dc435bb386 100644
--- a/res/css/views/elements/_DesktopCapturerSourcePicker.scss
+++ b/res/css/views/elements/_DesktopCapturerSourcePicker.scss
@@ -16,58 +16,42 @@ limitations under the License.
 
 .mx_desktopCapturerSourcePicker {
     overflow: hidden;
-}
 
-.mx_desktopCapturerSourcePicker_tabLabels {
-    display: flex;
-    padding: 0 0 8px 0;
-}
+    .mx_desktopCapturerSourcePicker_tab {
+        display: flex;
+        flex-wrap: wrap;
+        justify-content: center;
+        align-items: flex-start;
+        height: 500px;
+        overflow: overlay;
+    }
 
-.mx_desktopCapturerSourcePicker_tabLabel,
-.mx_desktopCapturerSourcePicker_tabLabel_selected {
-    width: 100%;
-    text-align: center;
-    border-radius: 8px;
-    padding: 8px 0;
-    font-size: $font-13px;
-}
+    .mx_desktopCapturerSourcePicker_source {
+        display: flex;
+        flex-direction: column;
+        margin: 8px;
+    }
 
-.mx_desktopCapturerSourcePicker_tabLabel_selected {
-    background-color: $tab-label-active-bg-color;
-    color: $tab-label-active-fg-color;
-}
+    .mx_desktopCapturerSourcePicker_source_thumbnail {
+        margin: 4px;
+        width: 312px;
+        border-width: 2px;
+        border-radius: 8px;
+        border-style: solid;
+        border-color: transparent;
 
-.mx_desktopCapturerSourcePicker_panel {
-    display: flex;
-    flex-wrap: wrap;
-    justify-content: center;
-    align-items: flex-start;
-    height: 500px;
-    overflow: overlay;
-}
+        &.mx_desktopCapturerSourcePicker_source_thumbnail_selected,
+        &:hover,
+        &:focus {
+            border-color: $accent-color;
+        }
+    }
 
-.mx_desktopCapturerSourcePicker_stream_button {
-    display: flex;
-    flex-direction: column;
-    margin: 8px;
-    border-radius: 4px;
-}
-
-.mx_desktopCapturerSourcePicker_stream_button_selected,
-.mx_desktopCapturerSourcePicker_stream_button:hover,
-.mx_desktopCapturerSourcePicker_stream_button:focus {
-    background: $roomtile-selected-bg-color;
-}
-
-.mx_desktopCapturerSourcePicker_stream_thumbnail {
-    margin: 4px;
-    width: 312px;
-}
-
-.mx_desktopCapturerSourcePicker_stream_name {
-    margin: 0 4px;
-    white-space: nowrap;
-    text-overflow: ellipsis;
-    overflow: hidden;
-    width: 312px;
+    .mx_desktopCapturerSourcePicker_source_name {
+        margin: 0 4px;
+        white-space: nowrap;
+        text-overflow: ellipsis;
+        overflow: hidden;
+        width: 312px;
+    }
 }
diff --git a/src/components/views/elements/DesktopCapturerSourcePicker.tsx b/src/components/views/elements/DesktopCapturerSourcePicker.tsx
index 49a2bda1f7..0fdddaa3ef 100644
--- a/src/components/views/elements/DesktopCapturerSourcePicker.tsx
+++ b/src/components/views/elements/DesktopCapturerSourcePicker.tsx
@@ -51,22 +51,22 @@ export class ExistingSource extends React.Component<ExistingSourceIProps> {
     };
 
     render() {
-        const classes = classNames({
-            mx_desktopCapturerSourcePicker_stream_button: true,
-            mx_desktopCapturerSourcePicker_stream_button_selected: this.props.selected,
+        const thumbnailClasses = classNames({
+            mx_desktopCapturerSourcePicker_source_thumbnail: true,
+            mx_desktopCapturerSourcePicker_source_thumbnail_selected: this.props.selected,
         });
 
         return (
             <AccessibleButton
-                className={classes}
+                className="mx_desktopCapturerSourcePicker_source"
                 title={this.props.source.name}
                 onClick={this.onClick}
             >
                 <img
-                    className="mx_desktopCapturerSourcePicker_stream_thumbnail"
+                    className={thumbnailClasses}
                     src={this.props.source.thumbnailURL}
                 />
-                <span className="mx_desktopCapturerSourcePicker_stream_name">{this.props.source.name}</span>
+                <span className="mx_desktopCapturerSourcePicker_source_name">{this.props.source.name}</span>
             </AccessibleButton>
         );
     }
@@ -147,7 +147,7 @@ export default class DesktopCapturerSourcePicker extends React.Component<
         });
 
         return new Tab(type, label, null, (
-            <div className="mx_desktopCapturerSourcePicker_panel">
+            <div className="mx_desktopCapturerSourcePicker_tab">
                 { sources }
             </div>
         ));