From 3292991491b8dec2fc35d91999e135f0fe95b67f Mon Sep 17 00:00:00 2001 From: Bruno Windels Date: Thu, 13 Feb 2020 17:29:38 +0100 Subject: [PATCH] provide specific label for when accepting/declining is in progress also distuingish between cancelling and declining --- .../views/messages/MKeyVerificationRequest.js | 24 +++++++++++++++---- src/i18n/strings/en_EN.json | 4 ++++ 2 files changed, 23 insertions(+), 5 deletions(-) diff --git a/src/components/views/messages/MKeyVerificationRequest.js b/src/components/views/messages/MKeyVerificationRequest.js index 0f5f417dbc..d02319119e 100644 --- a/src/components/views/messages/MKeyVerificationRequest.js +++ b/src/components/views/messages/MKeyVerificationRequest.js @@ -94,10 +94,20 @@ export default class MKeyVerificationRequest extends React.Component { _cancelledLabel(userId) { const client = MatrixClientPeg.get(); const myUserId = client.getUserId(); + const {cancellationCode} = this.props.mxEvent.verificationRequest; + const declined = cancellationCode === "m.user"; if (userId === myUserId) { - return _t("You cancelled"); + if (declined) { + return _t("You declined"); + } else { + return _t("You cancelled"); + } } else { - return _t("%(name)s cancelled", {name: getNameForEventRoom(userId, this.props.mxEvent.getRoomId())}); + if (declined) { + return _t("%(name)s declined", {name: getNameForEventRoom(userId, this.props.mxEvent.getRoomId())}); + } else { + return _t("%(name)s cancelled", {name: getNameForEventRoom(userId, this.props.mxEvent.getRoomId())}); + } } } @@ -116,15 +126,19 @@ export default class MKeyVerificationRequest extends React.Component { let subtitle; let stateNode; - const accepted = request.ready || request.started || request.done; - if (accepted || request.cancelled) { + if (!request.canAccept) { let stateLabel; + const accepted = request.ready || request.started || request.done; if (accepted) { stateLabel = ( {this._acceptedLabel(request.receivingUserId)} ); - } else { + } else if (request.cancelled) { stateLabel = this._cancelledLabel(request.cancellingUserId); + } else if (request.accepting) { + stateLabel = _t("accepting …"); + } else if (request.declining) { + stateLabel = _t("declining …"); } stateNode = (
{stateLabel}
); } diff --git a/src/i18n/strings/en_EN.json b/src/i18n/strings/en_EN.json index 7a8642be95..eb0a66b79f 100644 --- a/src/i18n/strings/en_EN.json +++ b/src/i18n/strings/en_EN.json @@ -1239,8 +1239,12 @@ "%(name)s cancelled verifying": "%(name)s cancelled verifying", "You accepted": "You accepted", "%(name)s accepted": "%(name)s accepted", + "You declined": "You declined", "You cancelled": "You cancelled", + "%(name)s declined": "%(name)s declined", "%(name)s cancelled": "%(name)s cancelled", + "accepting …": "accepting …", + "declining …": "declining …", "%(name)s wants to verify": "%(name)s wants to verify", "You sent a verification request": "You sent a verification request", "Error decrypting video": "Error decrypting video",