From 45140cab694ff5003c5d378cc7230be281fe0f46 Mon Sep 17 00:00:00 2001 From: Travis Ralston Date: Sat, 4 Nov 2017 19:52:42 -0700 Subject: [PATCH] Don't assume `false` means "use state" Signed-off-by: Travis Ralston --- src/components/structures/UserSettings.js | 6 +++--- src/components/views/elements/SettingsFlag.js | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/components/structures/UserSettings.js b/src/components/structures/UserSettings.js index 342680e8da..b3d2e92155 100644 --- a/src/components/structures/UserSettings.js +++ b/src/components/structures/UserSettings.js @@ -763,9 +763,9 @@ module.exports = React.createClass({ return (
+ label={setting.label} + level={SettingLevel.DEVICE} + onChange={setting.fn} />
); }, diff --git a/src/components/views/elements/SettingsFlag.js b/src/components/views/elements/SettingsFlag.js index 3640b5538e..cb6a001cf4 100644 --- a/src/components/views/elements/SettingsFlag.js +++ b/src/components/views/elements/SettingsFlag.js @@ -54,12 +54,12 @@ module.exports = React.createClass({ if (this.props.onChange) this.props.onChange(newState); }, - save: function(val = null) { + save: function(val = undefined) { return SettingsStore.setValue( this.props.name, this.props.roomId, this.props.level, - val ? val : this.state.value + val !== undefined ? val : this.state.value ); },