From 4b43e39d2aa0bf151384ed910b4a7df6c92bc4cb Mon Sep 17 00:00:00 2001
From: Jason Robinson <mail@jasonrobinson.me>
Date: Tue, 8 Sep 2020 11:31:40 +0300
Subject: [PATCH] Code review related changes

* drop room ID from jitsi widget data
* reame queryParts variable
---
 src/CallHandler.js       | 1 -
 src/utils/WidgetUtils.js | 6 +++---
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/CallHandler.js b/src/CallHandler.js
index 1a1c71b55f..27e8e34e16 100644
--- a/src/CallHandler.js
+++ b/src/CallHandler.js
@@ -416,7 +416,6 @@ async function _startCallApp(roomId, type) {
         isAudioOnly: type === 'voice',
         domain: jitsiDomain,
         auth: jitsiAuth,
-        roomId: roomId,
     };
 
     const widgetId = (
diff --git a/src/utils/WidgetUtils.js b/src/utils/WidgetUtils.js
index c9666d90d5..d5f6981476 100644
--- a/src/utils/WidgetUtils.js
+++ b/src/utils/WidgetUtils.js
@@ -450,7 +450,7 @@ export default class WidgetUtils {
 
     static getLocalJitsiWrapperUrl(opts: {forLocalRender?: boolean, auth?: string}={}) {
         // NB. we can't just encodeURIComponent all of these because the $ signs need to be there
-        const queryParts = [
+        const queryStringParts = [
             'conferenceDomain=$domain',
             'conferenceId=$conferenceId',
             'isAudioOnly=$isAudioOnly',
@@ -460,9 +460,9 @@ export default class WidgetUtils {
             'roomId=$matrix_room_id',
         ];
         if (opts.auth) {
-            queryParts.push(`auth=${opts.auth}`);
+            queryStringParts.push(`auth=${opts.auth}`);
         }
-        const queryString = queryParts.join('&');
+        const queryString = queryStringParts.join('&');
 
         let baseUrl = window.location;
         if (window.location.protocol !== "https:" && !opts.forLocalRender) {